Skip to content

Conversation

d3flex
Copy link

@d3flex d3flex commented Oct 6, 2025

Automate the livepatch isos posts. Due to the logic of the script generation this commit contains an injection of a for loop for all the livepatches which will be found in the spdx.json, after the sync in the server.

  • the loop always run even if no livepatches found. However it will only append to the isos posts the variable in the case that actually livepatch versions inclue in the array. The approach is just a bit dirty, as any other approach would require further and bigger changes.
  • The injection is in the rsync_iso after all the necessary variables are set and before the beginning writing to the print_openqa.sh. At that point the spdx.json should be available and it needs only to grep for the kernel_livepatch in the server. Before that point, the scriptgen.py would have to make a request to each repo in the dist.s.d and it is likely it would be less flexible as the logic of the isos post is mainly in the generated print_openqa.sh.

depends-on: https://gitlab.suse.de/openqa/openqa-trigger-from-ibs-plugin/-/merge_requests/263
issue: https://progress.opensuse.org/issues/188613

@d3flex d3flex added the do not merge Proposed changes that require further discussion label Oct 6, 2025
@d3flex
Copy link
Author

d3flex commented Oct 6, 2025

need testing on obs. as is for now, it breaks the print_openqa.sh for t/obs

@mdoucha
Copy link

mdoucha commented Oct 6, 2025

This approach will schedule tests for livepatch packages which haven't been updated in the product increment.

Automate the livepatch isos posts. Due to the logic of the script generation
this commit contains an injection of a for loop for all the livepatches which
will be found in the spdx.json, after the sync in the server.

- the loop always run even if no livepatches found. However it will only
append to the isos posts the variable in the case that actually livepatch
versions inclue in the array. The approach is just a bit dirty, as any other
approach would require further and bigger changes.
- The injection is in the `rsync_iso` after all the necessary variables are
set and before the beginning writing to the print_openqa.sh. At that point the
`spdx.json` should be available and it needs only to grep for the
_kernel_livepatch_ in the server. Before that point, the scriptgen.py would
have to make a request to each repo in the dist.s.d and it is likely it would
be less flexible as the logic of the _isos post_ is mainly in the generated
`print_openqa.sh`.

depends-on: https://gitlab.suse.de/openqa/openqa-trigger-from-ibs-plugin/-/merge_requests/263
issue: https://progress.opensuse.org/issues/188613
Signed-off-by: Ioannis Bonatakis <[email protected]>
@d3flex d3flex force-pushed the try/investigate_possible_issue branch from d01fe01 to c995f33 Compare October 6, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Proposed changes that require further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants