Skip to content

docs: rewrite OPL as practical guide#2588

Merged
vinckr merged 6 commits into
masterfrom
opl-update
Jul 3, 2026
Merged

docs: rewrite OPL as practical guide#2588
vinckr merged 6 commits into
masterfrom
opl-update

Conversation

@DavudSafarli

Copy link
Copy Markdown
Contributor

This PR rewrites OPL into a practical how-to guide covering namespaces, relations, subject-set references, and permits, each section with examples

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rewrites the Ory Permission Language (OPL) reference page from a formal specification into a practical how-to guide, introducing core modeling concepts (namespaces, relations, subject-set references, and permits) via short examples.

Changes:

  • Replaced the EBNF/spec-style content with a step-by-step, example-driven guide.
  • Added focused examples for unions, SubjectSet<...> references, includes, traverse, boolean operators, and permission composition.
  • Consolidated into a single “complete example” schema showing direct, group-based, and inherited access patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/keto/reference/ory-permission-language.mdx
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx
Comment thread docs/keto/reference/ory-permission-language.mdx
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
@DavudSafarli

Copy link
Copy Markdown
Contributor Author

@zepatrik i replied to your comments. There are few things to resolve about subjectsets and final example.

It's worth noting that reader ideally should read the other pages such as Namespaces/Objects/Subjects before jumping into OPL page. So, some understanding of the Namespace/Object/Subject should exist while reading this. This page is only for OPL reference. Not 1 page Keto guide.

Though, the other pages also need improvement, and overall sidebar needs improvements. As a reader, i alway preferred 1 long page docs compared to small separate pages.
Also, if we have more "how to model rbac/gdrive/notion" guides, then there are more changes for users/llms to understand the OPL to build the right model.

@DavudSafarli DavudSafarli requested a review from zepatrik June 1, 2026 10:36
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Jun 8, 2026

@zepatrik zepatrik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we're very close here. Probably the language needs a brush-up, but that can also be done by the docs people just rephrasing what is currently here.

Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx

@unatasha8 unatasha8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments from Slack

Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
Comment thread docs/keto/reference/ory-permission-language.mdx Outdated
@DavudSafarli DavudSafarli requested a review from unatasha8 July 2, 2026 07:11

@unatasha8 unatasha8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zepatrik zepatrik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this, we can still improve it later. It is good for now.

@vinckr vinckr merged commit 4594ef2 into master Jul 3, 2026
10 of 11 checks passed
@vinckr vinckr deleted the opl-update branch July 3, 2026 08:13
unatasha8 pushed a commit that referenced this pull request Jul 3, 2026
* docs: rewrite OPL as practical guide

* copilot reviews

* address review comments

* make final example better

* address review comments of una
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants