-
Notifications
You must be signed in to change notification settings - Fork 30
feat: add dockerfile output for Python builds #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add an example for this new feature to the
docs/source/pages/tutorials/rebuild_third_party_artifacts.rsttutorial. - Add the
dockerformat to the--output-formatCLI arg description. - Update
docs/source/pages/cli_usage/command_gen_build_spec.rst.
61a5195 to
853852b
Compare
behnazh-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an integration test for the docker package used in the tutorial, and use the tutorial tag. For now, we can just compare the dockerfile output with the expected Dockerfile.
fac36f4 to
98a9b5e
Compare
Signed-off-by: Abhinav Pradeep <[email protected]>
Signed-off-by: Abhinav Pradeep <[email protected]>
Signed-off-by: Abhinav Pradeep <[email protected]>
…ion. Signed-off-by: Abhinav Pradeep <[email protected]>
…us warnings. Signed-off-by: Abhinav Pradeep <[email protected]>
c6dd99b to
1db6614
Compare
Summary
Adds option "dockerfile" to the --output-format flag for gen-build-spec. For Python packages, it generates a dockerfile built on the
oraclelinux:9image to rebuild the package.Description of changes
build_spec_generator.pyto add functionality to infer the latest Python interpreter version satisfying the packages constraints, and generate a dockerfile that would build that Python interpreter from source. The dockerfile then proceeds to use that built interpreter to build the package itself.