Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions Sources/ODP/OdpEventManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,20 @@ open class OdpEventManager {

func identifyUser(vuid: String?, userId: String?) {
var identifiers = [String: String]()
if let _vuid = vuid {
identifiers[Constants.ODP.keyForVuid] = _vuid
if let vuid = vuid, !vuid.isEmpty {
identifiers[Constants.ODP.keyForVuid] = vuid
}
if let userId = userId {
if let userId = userId, !userId.isEmpty {
identifiers[Constants.ODP.keyForUserId] = userId
}


// Identify requires 2+ identifiers to link (e.g., vuid + fs_user_id).
// A single identifier has no cross-reference value and generates unnecessary traffic.
guard identifiers.count >= 2 else {
logger.d("ODP identify event is not dispatched (fewer than 2 valid identifiers).")
return
}

sendEvent(type: Constants.ODP.eventType,
action: "identified",
identifiers: identifiers,
Expand Down
12 changes: 4 additions & 8 deletions Tests/OptimizelyTests-Common/OdpEventManagerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,11 @@ class OdpEventManagerTests: XCTestCase {
validateData(evt.data, customData: [:])
}

func testIdentifyUser_noApiKey_nilUserId() {
func testIdentifyUser_noApiKey_nilUserId_singleIdentifier() {
manager.identifyUser(vuid: "v1", userId: nil)

XCTAssertEqual(1, manager.eventQueue.count)
let evt = manager.eventQueue.getFirstItem()!
XCTAssertEqual("fullstack", evt.type)
XCTAssertEqual("identified", evt.action)
XCTAssertEqual(["vuid": "v1"], evt.identifiers)
validateData(evt.data, customData: [:])

// single identifier should be skipped (not queued)
XCTAssertEqual(0, manager.eventQueue.count)
}

func testSendEvent_apiKey() {
Expand Down
Loading