[FSSDK-12394] chore: local holdout logic behind FeatureGates flag#631
Merged
Conversation
Default false to suppress local holdout logic until backend is ready. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Both experiment rule and delivery rule local holdout checks are now gated. When false, these blocks are skipped entirely. Global holdout evaluation in getDecisionForFlag() is unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
All holdout test classes set the gate to true in setUp and reset to false in tearDown. Existing test methods are unchanged — they pass because the gate enables the local holdout code paths during test execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…bility FeatureGates.swift was not registered in the Xcode project pbxproj file, causing build failures. Moving into Constants.swift which is already included in all build targets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This test class also uses local holdout data (includedRules), so it needs the gate enabled during test execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Added super.tearDown() to DecisionServiceTests_Holdouts tearDown - Removed FeatureGates override from HoldoutConfigTests since it tests the data model directly, not the gated decision service path Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Coverage is 93.828% — muzahidul/feature-gate-local-holdouts into master. No base build found for |
muzahidul-opti
changed the title
muzahidul-opti
changed the title
… override Created BaseHoldoutTests class that automatically enables the FeatureGates.localHoldouts flag in setUp() and resets it in tearDown(). Updated all holdout test classes to inherit from this base class, removing duplicate feature gate setup code from individual test files. This centralizes feature gate management and ensures all holdout tests run with the feature enabled consistently. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
raju-opti
previously approved these changes
May 4, 2026
raju-opti
left a comment
raju-opti
left a comment
There was a problem hiding this comment.
Changes looks good. It would be good to add some tests verifying that feature gating is working properly, i.e holdouts is not evaluated when the flag is off.
Created FeatureGateTests_LocalHoldouts with 5 tests verifying: - Local holdouts are skipped when FeatureGates.localHoldouts = false - Local holdouts are evaluated when FeatureGates.localHoldouts = true - Global holdouts work regardless of flag state Updated CLAUDE.md with concise guidance on properly linking new test files to Xcode targets to prevent integration issues. Addresses PR #631 review feedback from Raju. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeatureGates.localHoldoutsstatic var (defaultfalse) toConstants.swiftDefaultDecisionService.swiftbehindif FeatureGates.localHoldoutsBaseHoldoutTestsclass that automatically enables the feature gate in setUp/tearDownBaseHoldoutTests, removing duplicate gate setup codeTest plan
swift buildandxcodebuildIssues