-
Notifications
You must be signed in to change notification settings - Fork 230
feat(docs): add @Sample annotation for documentation #2954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Choconaut
wants to merge
4
commits into
operator-framework:main
Choose a base branch
from
Choconaut:docs-sample-annotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
500885f
feat(docs): add @Sample annotation for documentation
Choconaut b464359
refactor: remove unneeded properties in pom.xml
Choconaut feab885
feat: Implement SampleProcessor to generate md files
Choconaut 427cfa0
improve: remove unnecessary semicolon from SampleProcessor
Choconaut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>io.javaoperatorsdk</groupId> | ||
<artifactId>java-operator-sdk</artifactId> | ||
<version>5.1.3-SNAPSHOT</version> | ||
</parent> | ||
|
||
<artifactId>operator-annotations</artifactId> | ||
|
||
<properties> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
</properties> | ||
|
||
</project> |
26 changes: 26 additions & 0 deletions
26
operator-annotations/src/main/java/io/javaoperatorsdk/annotation/Sample.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package io.javaoperatorsdk.annotation; | ||
|
||
import java.lang.annotation.*; | ||
|
||
/** | ||
* This annotation marks an integration test class as a sample for the documentation. | ||
* Intended for use on test classes only. | ||
* | ||
* <p><b>Example:</b> | ||
* <pre>{@code | ||
* @Sample( | ||
* tldr="Usage of PrimaryToSecondaryMapper", | ||
* description="Showcases the usage of PrimaryToSecondaryMapper, in what situation it needs to be used and how to optimize typical uses with Informer indexes." | ||
* ) | ||
* class PrimaryToSecondaryIT { | ||
* // details omitted | ||
* } | ||
* }</pre> | ||
*/ | ||
@Target(ElementType.TYPE) | ||
@Retention(RetentionPolicy.SOURCE) | ||
@Documented | ||
public @interface Sample { | ||
String tldr(); | ||
String description(); | ||
} |
96 changes: 96 additions & 0 deletions
96
operator-annotations/src/main/java/io/javaoperatorsdk/processor/SampleProcessor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
package io.javaoperatorsdk.processor; | ||
|
||
import javax.annotation.processing.AbstractProcessor; | ||
import javax.annotation.processing.RoundEnvironment; | ||
import javax.annotation.processing.SupportedAnnotationTypes; | ||
import javax.lang.model.element.*; | ||
import javax.lang.model.util.Types; | ||
import javax.tools.FileObject; | ||
import javax.tools.StandardLocation; | ||
import java.io.IOException; | ||
import java.io.Writer; | ||
import java.util.*; | ||
|
||
/** | ||
* Annotation processor that generates a markdown file listing all classes annotated with @Sample. | ||
*/ | ||
@SupportedAnnotationTypes("io.javaoperatorsdk.annotation.Sample") | ||
public class SampleProcessor extends AbstractProcessor { | ||
|
||
private record SampleInfo(String tldr, String description) {} | ||
private final List<SampleInfo> samples = new ArrayList<>(); | ||
|
||
@Override | ||
public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) { | ||
|
||
Types types = processingEnv.getTypeUtils(); | ||
for (TypeElement annotation: annotations) { | ||
// element has details about the class being annotated, but not the values | ||
// ex: String tldr = ..., it knows it has a field called tldr but not what's assigned | ||
for (Element element : roundEnv.getElementsAnnotatedWith(annotation)) { | ||
// a mirror gives access to the values assigned to the fields of the annotation | ||
// element.getAnnotation does not work since the retention is SOURCE | ||
AnnotationMirror annotationMirror = element.getAnnotationMirrors().stream() | ||
.filter(am -> types.isSameType(am.getAnnotationType(), annotation.asType())) | ||
.findFirst() | ||
.orElse(null); | ||
|
||
if (annotationMirror != null) { | ||
String tldr = getString(annotationMirror.getElementValues(), "tldr"); | ||
String description = getString(annotationMirror.getElementValues(), "description"); | ||
|
||
samples.add(new SampleInfo(tldr, description) ); | ||
} | ||
} | ||
} | ||
|
||
if (roundEnv.processingOver()) { | ||
// sort to keep the order stable | ||
samples.sort(Comparator.comparing(SampleInfo::tldr, String.CASE_INSENSITIVE_ORDER)); | ||
writeSampleMDFile(samples); | ||
} | ||
return false; | ||
} | ||
|
||
/** | ||
* | ||
*/ | ||
private void writeSampleMDFile(List<SampleInfo> samples) { | ||
try { | ||
FileObject fileObject = processingEnv.getFiler() | ||
.createResource(StandardLocation.CLASS_OUTPUT, "", "samples.md"); | ||
|
||
try(Writer writer = fileObject.openWriter()) { | ||
writer.write("# Integration Test Samples \n"); | ||
|
||
for (SampleInfo sample : samples) { | ||
writer.write("## " + sample.tldr() + "\n"); | ||
writer.write(sample.description() + "\n\n"); | ||
} | ||
} catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} | ||
|
||
} catch (Exception e) { | ||
throw new RuntimeException(e); | ||
} | ||
} | ||
|
||
/** | ||
* Extracts a string value from the annotation values map. | ||
* @param vals the map of annotation values | ||
* @param name the name of the field to extract | ||
* @return the string value, or empty string if not found | ||
*/ | ||
private String getString( | ||
Map<? extends ExecutableElement, ? extends AnnotationValue> vals, String name) { | ||
for (Map.Entry<? extends ExecutableElement, ? extends AnnotationValue> ev : vals.entrySet()) { | ||
if (ev.getKey().getSimpleName().contentEquals(name)) { | ||
Object value = ev.getValue().getValue(); | ||
return value == null ? "" : value.toString(); | ||
} | ||
} | ||
// should not happen since tldr and description are mandatory | ||
return ""; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty Javadoc comment should either be removed or contain meaningful documentation describing the method's purpose, parameters, and behavior.
Copilot uses AI. Check for mistakes.