feat(consistent-gslc): drop frames with no standard-mode stack - #25
Merged
Conversation
A frame observed only in engineering or test modes used to fall back to a winner among those modes, which put a stack DISP-NISAR cannot process into the output. Such frames are now left out. --keep-nonstandard-modes restores the old fallback for inspecting what was dropped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
create-consistentnow leaves out any (track, frame) whose acquisitions are allin non-standard modes, instead of picking a winner among them. A new
--keep-nonstandard-modesflag restores the old fallback._common_mode_coveragereturnsNonefor such a frame, and the per-frame mergein
select_consistent_acquisitionsbecame an inner join so those acquisitionsdrop out. The CLI reports the count:
Why
Only
4005and2005are science modes. A frame seen only in7700or0505has no stack DISP-NISAR can process, so emitting one put an unusable entry into
the consistent-GSLC JSON that every downstream database then inherited —
reference dates and processing-mode labels included.
Verify
The regression fixture's frame (200, 300) is
7700-only: it is now absent fromthe output, and a new test asserts
--keep-nonstandard-modesbrings it back as7700_P.Note for reviewers
The docs in this PR also pick up a handful of
create-catalog->create-gslc-csvtext updates from #24. Those lines live in the same files as this change and were
not worth an interactive hunk split; they are documentation strings only.
Pre-flight
pre-commit run --all-files: clean.pytest: 172 passed.🤖 Generated with Claude Code