Skip to content

Add support for extra options in the capture profile dialog. #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for extra options in the capture profile dialog. #1819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...tend/app/components/capture_profile/capture_profile_dialog/capture_profile_dialog.ng.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,20 @@
/>
</mat-form-field>
</div>

<div>
Extra Options:
<div *ngFor="let option of extraOptions; let i = index">
<mat-form-field>
<input matInput placeholder="Key" [(ngModel)]="option.key" />
</mat-form-field>
<mat-form-field>
<input matInput placeholder="Value" [(ngModel)]="option.value" />
</mat-form-field>
<button mat-button (click)="removeExtraOption(i)">Remove</button>
</div>
<button mat-button (click)="addExtraOption()">Add Option</button>
</div>
</mat-expansion-panel>
</div>
</mat-dialog-content>
Expand Down
19 changes: 17 additions & 2 deletions frontend/app/components/capture_profile/capture_profile_dialog/capture_profile_dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export class CaptureProfileDialog {
deviceTracerLevel = '1';
pythonTracerLevel = '0';
delay = 0;
extraOptions: Array<{key: string, value: string}> = [];

constructor(private readonly dialogRef:
MatDialogRef<CaptureProfileDialog>) {}
Expand All @@ -37,7 +38,7 @@ export class CaptureProfileDialog {
}

captureProfile() {
this.dialogRef.close({
const options: {[key: string]: string|number|boolean} = {
serviceAddr: this.serviceAddr,
isTpuName: this.isTpuName,
duration: this.duration,
Expand All @@ -47,10 +48,24 @@ export class CaptureProfileDialog {
deviceTracerLevel: Number(this.deviceTracerLevel),
pythonTracerLevel: Number(this.pythonTracerLevel),
delay: this.delay,
});
};

for (const option of this.extraOptions) {
options[option.key] = option.value;
}

this.dialogRef.close(options);
}

close() {
this.dialogRef.close();
}

addExtraOption() {
this.extraOptions.push({key: '', value: ''});
}

removeExtraOption(index: number) {
this.extraOptions.splice(index, 1);
}
}