[EXCH-13319] Provide GPP params for user sync#17
Closed
Kacper Fus (Fuska1) wants to merge 4 commits intomasterfrom
Closed
[EXCH-13319] Provide GPP params for user sync#17Kacper Fus (Fuska1) wants to merge 4 commits intomasterfrom
Kacper Fus (Fuska1) wants to merge 4 commits intomasterfrom
Conversation
Kacper Fus (Fuska1)
requested review from
Rafał Sieczka (bukrain),
Gabriela Międlar (gmiedlar-ox) and
Serhii Nesprava (sergseven)
| @@ -0,0 +1,99 @@ | |||
| { | |||
There was a problem hiding this comment.
minor
What is the purpose of this test?
From what I found in user sync in prebid server can only be tested manually
https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#user-sync-testing
Also in the page below from what I see we can find how it works
https://docs.prebid.org/prebid-server/developers/pbs-cookie-sync.html#bidder-instructions-for-building-a-sync-endpoint
Author
There was a problem hiding this comment.
I see, thanks for pointing that out, so i agree with you that this test is unnecessary.
Gabriela Międlar (gmiedlar-ox)
approved these changes
Jul 18, 2025
Rafał Sieczka (bukrain)
approved these changes
Jul 18, 2025
Author
|
merged in prebid#4445 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.