Openx bid adapter: support for MAP requests by bukrain · Pull Request #102 · openx/Prebid.js

Rafał Sieczka (bukrain) · 2026-02-20T07:31:30Z

Type of change

Description of change

Other information

karol.szawlis (KarolSzawlisOpenX) · 2026-02-20T10:15:53Z

test/spec/modules/openxBidAdapter_spec.js

+        bidRequestsWithMediaTypes[0].params.delDomain = 'domain-a.test';
+        bidRequestsWithMediaTypes[1].params.delDomain = 'domain-b.test';
+        const request = spec.buildRequests(bidRequestsWithMediaTypes, mockBidderRequest);
+        expect(request[0].data.ext.delDomain).to.equal('domain-a.test');


[question] Now bids with different delDomains into one request and only first bid's delDomain is sent and others are dropped?

Gabriela Międlar (gmiedlar-ox)

lgtm

libraries/webdriver/webdriver.js

modules/51DegreesRtdProvider.js

  deepSetNotEmptyValue(qs, '51D_ScreenPixelsHeight', _window?.screen?.height);
  deepSetNotEmptyValue(qs, '51D_ScreenPixelsWidth', _window?.screen?.width);
-  deepSetNotEmptyValue(qs, '51D_PixelRatio', _window?.devicePixelRatio);
+  deepSetNotEmptyValue(qs, '51D_PixelRatio', getDevicePixelRatio(_window));


Coveralls (coveralls) · 2026-03-03T12:22:39Z

Pull Request Test Coverage Report for Build 22619502230

Details

41 of 41 (100.0%) changed or added relevant lines in 2 files are covered.
247 unchanged lines in 25 files lost coverage.
Overall coverage increased (+0.05%) to 92.88%

Files with Coverage Reduction	New Missed Lines	%
test/spec/integration/faker/googletag.js	1	91.3%
test/spec/modules/gumgumBidAdapter_spec.js	1	99.51%
test/spec/unit/secureCreatives_spec.js	1	97.87%
libraries/medianetUtils/logger.js	2	85.88%
libraries/omsUtils/index.js	2	70.0%
modules/limelightDigitalBidAdapter.js	2	89.87%
modules/relaidoBidAdapter.js	2	92.58%
src/targeting.ts	2	95.28%
test/spec/modules/intentIqIdSystem_spec.js	2	96.82%
modules/mediasquareBidAdapter.js	3	89.53%

Totals
Change from base Build 22297321905:	0.05%
Covered Lines:	217317
Relevant Lines:	225609

💛 - Coveralls

github-actions · 2026-03-12T07:09:46Z

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

modules/openxBidAdapter.js (+2 errors)

* MediaFuse Adapter: Fixed Test Issues * Fixed Lint Issue * fix video vastUrl not set on openrtb2 endpoint * Fixed lint errors * Fixed PR Flagged Issues --------- Co-authored-by: unknown <indrajit@oncoredigital.com>

…#14578) * Core: fix error handling when loading debugging-standalone * lint * run error callback once * Separate build-release from prepare-release

…4476) * New Magnite Bid Adapter ORTB Converter * Update modules/magniteBidAdapter.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * codex suggestions * move outstream to shared util * fix tests * Update libraries/magniteUtils/outstream.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * revoke blob after ttl * translate adm_native if needed * remove transform bid params * set alwaysHasCapacity * fix lint --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>

* Core: bid targeting exclusion * passing filteredBids to exclusion function * Add disableFingerprintingApis option in config Added option to disable specific fingerprinting APIs. * Update config.ts * handling exceptions * Update bidTargetingExclusion documentation Clarify the description of bidTargetingExclusion function. --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Patrick McCann <patmmccann@gmail.com>

Added guidelines for common adapter types and type references.

Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.1 to 3.4.1. - [Commits](WebReflection/flatted@v3.3.1...v3.4.1) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [undici](https://github.com/nodejs/undici) from 6.23.0 to 6.24.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.23.0...v6.24.1) --- updated-dependencies: - dependency-name: undici dependency-version: 6.24.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ustness (prebid#14530) * Holid: respect auction timeout, safer ortb merges, improve usersync * Holid Bid Adapter: add unit tests * chore: re-run CI

* feat(adapter): ts implementation * feat(adapter): removed amx support * test: added tests * fix(bid-adapter): renamed file * fix(library): folder name * update(bid-adapter): imported module * update: test creds in adUnit * fix(cookie): added guard on object slicing * fix(enrichImp): removed divId parameter * fix(tests): adapted test w/o divId --------- Co-authored-by: Mickael van der Beek <mickael.van.der.beek+github@gmail.com>

* gppControl modules: add missing transmitUfpd check * Update activityControls.js --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.4.1 to 5.5.6. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.4.1...v5.5.6) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.5.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…id#14598) * 51d: populate device.hwv + optionally use hardwarenameprefix as device.module * 51d update doc * fix typo

* adtelligentBidAdapter-update * lint fix --------- Co-authored-by: k-piekharieva <k.piekharieva@adtelligent.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>

* Reformat import statements in gravityBidAdapter * Fix import statement formatting for Renderer * Fix formatting of cookies in user sync test * Format code for consistency in buildRequests function

* Change beopid cookie to caudid * Add caudid_date cookie * Post review commit

Bumps [socket.io-parser](https://github.com/socketio/socket.io) from 4.2.4 to 4.2.6. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-parser@4.2.4...socket.io-parser@4.2.6) --- updated-dependencies: - dependency-name: socket.io-parser dependency-version: 4.2.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

github-actions · 2026-03-19T09:42:17Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js
modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js
modules/adrelevantisBidAdapter.js has 23 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 24 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 26 duplicated lines with modules/pixfutureBidAdapter.js
modules/adnuntiusAnalyticsAdapter.js has 24 duplicated lines with modules/livewrappedAnalyticsAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2026-03-19T09:43:03Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

libraries/bidViewabilityPixels/index.js
libraries/magniteUtils/outstream.js
modules/magniteBidAdapter.js

modules/performaxBidAdapter.js

+/**
+ * Serializes and stores data.
+ * @param {string} key - The unique identifier
+ * @param {any} value - The data to store


modules/performaxBidAdapter.js

+  }
+
+  const data = { type, payload };
+  const options = { method: 'POST', withCredentials: true, contentType: 'application/json' };


modules/deepintentBidAdapter.js

+      openRtbBidRequest.bcat = bcat;
+    }
+    if (isArray(badv) && badv.length > 0) {
+      openRtbBidRequest.badv = badv;


github-actions · 2026-03-19T12:05:23Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js
modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js
modules/adrelevantisBidAdapter.js has 23 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 24 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 26 duplicated lines with modules/pixfutureBidAdapter.js
modules/adnuntiusAnalyticsAdapter.js has 24 duplicated lines with modules/livewrappedAnalyticsAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2026-03-19T12:06:14Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

libraries/bidViewabilityPixels/index.js
libraries/magniteUtils/outstream.js
modules/magniteBidAdapter.js

* Core: allow vast xml without using cache * renaming

github-actions · 2026-03-20T08:22:11Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js
modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js
modules/adrelevantisBidAdapter.js has 23 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 24 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 26 duplicated lines with modules/pixfutureBidAdapter.js
modules/adnuntiusAnalyticsAdapter.js has 24 duplicated lines with modules/livewrappedAnalyticsAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2026-03-20T08:23:06Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

libraries/bidViewabilityPixels/index.js
libraries/magniteUtils/outstream.js
modules/magniteBidAdapter.js

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.5.6 to 5.5.7. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.5.6...v5.5.7) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.5.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [flatted](https://github.com/WebReflection/flatted) from 3.4.1 to 3.4.2. - [Commits](WebReflection/flatted@v3.4.1...v3.4.2) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create datamage RTD integration * remove test.html files * update example.html * siplify architecture, adding back in linting, improve load * fixed caching issues and bot comments from original pr * fix issues identified by bot * replace dep GPT api calls to modern format * update btoa to support non typical url encodings, strip common tracking params * remove misc local test files * fix fetchPromise transient failur potential * reduce key value size and unusued keys in payload to gam and ortb * update Rtd spec file naming * update prebid js path in example * include datamageRtdprovider in submodules json

Added review guidelines for PR reviews and module rules. Work in progress

github-actions · 2026-03-20T13:24:52Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
modules/marsmediaBidAdapter.js has 16 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 75 duplicated lines with modules/rhythmoneBidAdapter.js
modules/marsmediaBidAdapter.js has 14 duplicated lines with modules/onomagicBidAdapter.js
modules/marsmediaBidAdapter.js has 26 duplicated lines with modules/rhythmoneBidAdapter.js
modules/connectadBidAdapter.js has 25 duplicated lines with modules/consumableBidAdapter.js
modules/adrelevantisBidAdapter.js has 23 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 24 duplicated lines with modules/winrBidAdapter.js
modules/adrelevantisBidAdapter.js has 26 duplicated lines with modules/pixfutureBidAdapter.js
modules/adnuntiusAnalyticsAdapter.js has 24 duplicated lines with modules/livewrappedAnalyticsAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2026-03-20T13:25:33Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

libraries/bidViewabilityPixels/index.js
libraries/magniteUtils/outstream.js
modules/datamageRtdProvider.js
modules/magniteBidAdapter.js

Marcin Wrobel (marcin-wrobel-ox) and others added 5 commits February 13, 2026 16:39

WIP deduplicate request

719568d

Cleanup of tests and buildRequest function

a9c8b43

Improve tests

27eff87

Revert changing platformID in test

a5e7778

Add additional tests

13172aa

Rafał Sieczka (bukrain) marked this pull request as ready for review February 20, 2026 09:36

Rafał Sieczka (bukrain) requested review from Kacper Fus (Fuska1), karol.szawlis (KarolSzawlisOpenX), Gabriela Międlar (gmiedlar-ox) and Marcin Wrobel (marcin-wrobel-ox) February 20, 2026 09:37

karol.szawlis (KarolSzawlisOpenX) reviewed Feb 20, 2026

View reviewed changes

Gabriela Międlar (gmiedlar-ox) approved these changes Feb 20, 2026

View reviewed changes

Merge branch 'master' into wip-dedup-requests

088ef4a

github-advanced-security bot found potential problems Feb 23, 2026

View reviewed changes

Merge branch 'master' into wip-dedup-requests

82ff015

Rafał Sieczka (bukrain) changed the title ~~EXCH-12051 - Deduplicate requests~~ Openx bid adapter: support for MAP requests Mar 3, 2026

Rafał Sieczka (bukrain) added 3 commits March 12, 2026 08:00

Search banner imp by id in test

163229c

Format tests

f403d44

Merge branch 'master' into wip-dedup-requests

ac39f67

Rafał Sieczka (bukrain) and others added 9 commits March 12, 2026 09:39

Fix lint errors

8a91fe7

Mediafuse adapter update: resubmit refactor (prebid#14581)

dc526c7

* MediaFuse Adapter: Fixed Test Issues * Fixed Lint Issue * fix video vastUrl not set on openrtb2 endpoint * Fixed lint errors * Fixed PR Flagged Issues --------- Co-authored-by: unknown <indrajit@oncoredigital.com>

Build system: separate build-release from prepare-release (prebid…

217004b

…#14578) * Core: fix error handling when loading debugging-standalone * lint * run error callback once * Separate build-release from prepare-release

adloox analytics: do not disable if not enabled (prebid#14585)

2984a0e

Prebid 10.28.0 release

13cdc5a

Increment version to 10.28.1-pre

415eed0

Document common adapter types and references (prebid#14577)

8be6dfb

Added guidelines for common adapter types and type references.

dependabot bot and others added 12 commits March 15, 2026 07:06

Holid Bid Adapter: respect auction timeout, ORTB merges, usersync rob…

68b0534

…ustness (prebid#14530) * Holid: respect auction timeout, safer ortb merges, improve usersync * Holid Bid Adapter: add unit tests * chore: re-run CI

gppControl modules: add missing transmitUfpd check (prebid#14604)

6295bfb

* gppControl modules: add missing transmitUfpd check * Update activityControls.js --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>

51DegreesRtdProvider: populate device.hwv, improve device.model (preb…

318483d

…id#14598) * 51d: populate device.hwv + optionally use hardwarenameprefix as device.module * 51d update doc * fix typo

adtelligentBidAdapter: gather placement pos info (prebid#14555)

5b1e70f

* adtelligentBidAdapter-update * lint fix --------- Co-authored-by: k-piekharieva <k.piekharieva@adtelligent.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>

Reformat import statements in gravityBidAdapter (prebid#14610)

a7c82c8

* Reformat import statements in gravityBidAdapter * Fix import statement formatting for Renderer * Fix formatting of cookies in user sync test * Format code for consistency in buildRequests function

BeOpBidAdapter: Refacto beopid cookie to caudid (prebid#14584)

fcd64ea

* Change beopid cookie to caudid * Add caudid_date cookie * Post review commit

Merge branch 'master' into wip-dedup-requests

fa02081

github-advanced-security bot found potential problems Mar 19, 2026

View reviewed changes

Patrick McCann (patmmccann) and others added 2 commits March 19, 2026 06:38

Add 'device.ifa' to user paths in redactor.ts (prebid#14606)

6756249

Merge branch 'master' into wip-dedup-requests

b6f4a28

mkomorski and others added 2 commits March 19, 2026 13:01

Core: allow vast xml without using cache (prebid#14611)

6896fee

* Core: allow vast xml without using cache * renaming

Merge branch 'master' into wip-dedup-requests

3f98761

dependabot bot and others added 5 commits March 20, 2026 08:43

Update AGENTS.md with review guidelines (prebid#14612)

adf5a4f

Added review guidelines for PR reviews and module rules. Work in progress

Merge branch 'master' into wip-dedup-requests

65de0ad

Conversation

Rafał Sieczka (bukrain) commented Feb 20, 2026

Type of change

Description of change

Other information

Uh oh!

karol.szawlis (KarolSzawlisOpenX) Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Gabriela Międlar (gmiedlar-ox) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Check warning

Coveralls (coveralls) commented Mar 3, 2026

Pull Request Test Coverage Report for Build 22619502230

Details

💛 - Coveralls

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

Check warning

Check warning

Check warning

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants