Update iwinfo.c #15
Open
Update iwinfo.c #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemcrash
reviewed
Nov 12, 2025
Author
|
Thanks for the review! |
Contributor
|
Squash your commits |
The buffer 'res' was uninitialized before being passed to scanlist(), which could lead to garbage data in scan results. This patch ensures the buffer is zeroed out using memset before use. Signed-off-by: limao-cpu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer
resinrpc_iwinfo_scan()was previously uninitialized before being passed toiw->scanlist(). If the scan result was shorter than previous data, or not fully written, residual data could lead to garbage or incorrect output.This patch adds an explicit
memset(res, 0, sizeof(res));before the scan to ensure clean and consistent output, especially during repeated scans or partial data writes.Tested on OpenWrt with multiple interface scans to confirm stability.