adguardhome: use correct capabilities #28431
Closed
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous json file incorrectly granted CAP_NET_RAW, which AdGuardHome does not use for either DNS or DHCP AFAIK. CAP_NET_BIND_SERVICE is needed for binding privileged DNS and HTTPS ports and CAP_NET_ADMIN for DHCP functionality, matching guidance in the Linux capability documentation (man 7 capabilities, man 7 packet) and consistent with AdGuardHome’s DHCP implementation, which relies on packet sockets and interface operations rather than raw ICMP. If users are only using adguard for DNS, CAP_NET_ADMIN is not needed at all. Signed-off-by: John Audia <therealgraysky@proton.me>
Member
|
This is how it's documented:
Isn't Did you test the DHCP part? |
Contributor
Author
|
Well shit. I read it backwards. After reviewing the docs, and the man pages, I believe you had it right. Sorry for the noise. FYI - I tested with just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @GeorgeSapkin @dobo90
(You can find this by checking the history of the package
Makefile.)Description:
The previous json file incorrectly granted
CAP_NET_RAW, which AdGuardHome does not use for either DNS or DHCP AFAIK.CAP_NET_BIND_SERVICEis needed for binding privileged DNS and HTTPS ports andCAP_NET_ADMINfor DHCP functionality, matching guidance in the Linux capability documentation (man 7 capabilities, man 7 packet) and consistent with AdGuardHome’s DHCP implementation, which relies on packet sockets and interface operations rather than raw ICMP.If users are only using adguard for DNS,
CAP_NET_ADMINis not needed at all.🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.