Skip to content

[chores] Updated WHOIS blog post with final docs links #110#183

Merged
nemesifier merged 1 commit intomasterfrom
issues/110-update-gsoc25-whois-links
Mar 8, 2026
Merged

[chores] Updated WHOIS blog post with final docs links #110#183
nemesifier merged 1 commit intomasterfrom
issues/110-update-gsoc25-whois-links

Conversation

@nemesifier
Copy link
Member

Closes #110

@nemesifier nemesifier self-assigned this Mar 7, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cc4b47b1-cea0-4fdd-bf66-9845e02bfe60

📥 Commits

Reviewing files that changed from the base of the PR and between 3d60ed8 and acfdc77.

📒 Files selected for processing (1)
  • content/blog/gsoc-25-whois-and-ip-geolocation.rst
📜 Recent review details
🔇 Additional comments (2)
content/blog/gsoc-25-whois-and-ip-geolocation.rst (2)

175-181: Good update - narrative is now consistent.

The "Current state" section has been successfully updated to reflect that the features are merged and documented. This addresses the previous review concern about narrative inconsistency.

Minor observation: The documentation links are duplicated from lines 51-54. While this provides convenient reference, you might consider just referring readers to "the documentation pages mentioned above" to reduce redundancy, though the current approach is also acceptable.


51-54: No changes needed — documentation links are correct and follow project conventions.

Both documentation URLs are accessible (HTTP 200) and the /docs/dev/ path is the established convention used consistently across blog posts in the repository (including gsoc26-announcement.rst and roadmap-2030.rst). The links are appropriate for this GSoC project blog post.


📝 Walkthrough

Walkthrough

This PR updates the WHOIS and IP geolocation blog post to replace GitHub RST file links with permanent openwisp.io documentation pages for WHOIS Lookup and Estimated Location. It removes a detailed "Current state" block about branch/PR status and replaces it with a concise statement that WHOIS and Estimated Location features have been merged and are documented. Minor wording adjustments were made to reference the new documentation pages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the WHOIS blog post with final documentation links, which aligns with the changeset's updates to documentation references.
Description check ✅ Passed The description references issue #110, which directly relates to the changeset's purpose of updating WHOIS blog post documentation links.
Linked Issues check ✅ Passed The PR fulfills the objectives in issue #110 by updating links in the WHOIS blog post to point to final documentation locations after the gsoc25-whois feature was merged.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to issue #110; the blog post updates replace interim links with final documentation links as required.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issues/110-update-gsoc25-whois-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@content/blog/gsoc-25-whois-and-ip-geolocation.rst`:
- Around line 48-54: The "Current state" section still claims the WHOIS work
lives only on the gsoc25-whois branch and has pending PRs; update that narrative
to match the new documentation links (WHOIS Lookup and Estimated Location) by
either removing the outdated "Current state" paragraph or rewriting it to state
the features are documented in the main docs and list which PRs/commits were
merged (or give final statuses), and ensure the section header "Current state"
and any references to the gsoc25-whois branch, pending reviews, or unmerged PRs
(gsoc25-whois) are removed or converted to present-tense merged status.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 87ef5b8f-d86d-4603-9410-9d1747339156

📥 Commits

Reviewing files that changed from the base of the PR and between bc3f89c and 8866bcc.

📒 Files selected for processing (1)
  • content/blog/gsoc-25-whois-and-ip-geolocation.rst

@nemesifier nemesifier force-pushed the issues/110-update-gsoc25-whois-links branch from 8866bcc to 3d60ed8 Compare March 8, 2026 01:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
content/blog/gsoc-25-whois-and-ip-geolocation.rst (1)

1-1: ⚠️ Potential issue | 🔴 Critical

Fix the ReStructuredText formatting issue.

The CI pipeline is failing with a ReStructuredText formatting error. The file needs to be reformatted to pass the checks.

Run the RST formatter on this file to fix the formatting issues. The error message suggests the file can be auto-formatted. Typically, you can fix this by running the project's RST formatter or linter tool (check the repository's contributing guidelines for the specific command).

Common RST formatting issues include:

  • Trailing whitespace
  • Line length exceeding maximum limits
  • Inconsistent indentation
#!/bin/bash
# Description: Check for common RST formatting issues in the file

echo "Checking for trailing whitespace:"
cat content/blog/gsoc-25-whois-and-ip-geolocation.rst | grep -n " $" | head -20

echo -e "\nChecking for long lines (>79 characters):"
awk 'length>79 {print NR": "length" chars"}' content/blog/gsoc-25-whois-and-ip-geolocation.rst | head -20

echo -e "\nNote: Run the project's RST formatter to auto-fix these issues."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@content/blog/gsoc-25-whois-and-ip-geolocation.rst` at line 1, The RST file
titled "GSoC 2025: WHOIS Info and Estimated Geographic Locations" fails CI due
to ReStructuredText formatting; run the repository's RST formatter (or the
project's linter/pre-commit hook) on that file to remove trailing whitespace,
wrap long lines to the project's max line length, and fix inconsistent
indentation; specifically check for and remove trailing spaces, break lines over
~79 chars, and normalize section/title underline lengths so the document
compiles cleanly, then re-run the CI or linter to verify the fix.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@content/blog/gsoc-25-whois-and-ip-geolocation.rst`:
- Line 1: The RST file titled "GSoC 2025: WHOIS Info and Estimated Geographic
Locations" fails CI due to ReStructuredText formatting; run the repository's RST
formatter (or the project's linter/pre-commit hook) on that file to remove
trailing whitespace, wrap long lines to the project's max line length, and fix
inconsistent indentation; specifically check for and remove trailing spaces,
break lines over ~79 chars, and normalize section/title underline lengths so the
document compiles cleanly, then re-run the CI or linter to verify the fix.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 282ba9ab-30b3-4028-aefc-51321ce1d9dc

📥 Commits

Reviewing files that changed from the base of the PR and between 8866bcc and 3d60ed8.

📒 Files selected for processing (1)
  • content/blog/gsoc-25-whois-and-ip-geolocation.rst
📜 Review details
🧰 Additional context used
🪛 GitHub Actions: OpenWISP Website CI Build
content/blog/gsoc-25-whois-and-ip-geolocation.rst

[error] 1-1: ReStructuredText check failed. File could be reformatted.

🔇 Additional comments (2)
content/blog/gsoc-25-whois-and-ip-geolocation.rst (2)

175-179: Well done addressing the previous review feedback!

The "Current state" section has been properly updated to reflect that the features are now merged and documented. This resolves the inconsistency that was flagged in the previous review where the narrative still referred to the work being on the gsoc25-whois branch with pending PRs.

The new text is concise, accurate, and includes the appropriate documentation links.


51-54: The documentation links using /docs/dev/ paths are correct and appropriate. The stable documentation alternatives (/docs/stable/) do not exist for these features (return HTTP 404), meaning the development documentation is the only available reference. No changes are needed.

coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 8, 2026
@nemesifier nemesifier force-pushed the issues/110-update-gsoc25-whois-links branch from 3d60ed8 to acfdc77 Compare March 8, 2026 01:44
@nemesifier nemesifier merged commit acfdc77 into master Mar 8, 2026
2 of 3 checks passed
@nemesifier nemesifier deleted the issues/110-update-gsoc25-whois-links branch March 8, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[gsoc25] Update WHOIS blog post links to docs once merged

1 participant