[chores] Updated WHOIS blog post with final docs links #110#183
[chores] Updated WHOIS blog post with final docs links #110#183nemesifier merged 1 commit intomasterfrom
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details🔇 Additional comments (2)
📝 WalkthroughWalkthroughThis PR updates the WHOIS and IP geolocation blog post to replace GitHub RST file links with permanent openwisp.io documentation pages for WHOIS Lookup and Estimated Location. It removes a detailed "Current state" block about branch/PR status and replaces it with a concise statement that WHOIS and Estimated Location features have been merged and are documented. Minor wording adjustments were made to reference the new documentation pages. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/blog/gsoc-25-whois-and-ip-geolocation.rst`:
- Around line 48-54: The "Current state" section still claims the WHOIS work
lives only on the gsoc25-whois branch and has pending PRs; update that narrative
to match the new documentation links (WHOIS Lookup and Estimated Location) by
either removing the outdated "Current state" paragraph or rewriting it to state
the features are documented in the main docs and list which PRs/commits were
merged (or give final statuses), and ensure the section header "Current state"
and any references to the gsoc25-whois branch, pending reviews, or unmerged PRs
(gsoc25-whois) are removed or converted to present-tense merged status.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 87ef5b8f-d86d-4603-9410-9d1747339156
📒 Files selected for processing (1)
content/blog/gsoc-25-whois-and-ip-geolocation.rst
8866bcc to
3d60ed8
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/blog/gsoc-25-whois-and-ip-geolocation.rst (1)
1-1:⚠️ Potential issue | 🔴 CriticalFix the ReStructuredText formatting issue.
The CI pipeline is failing with a ReStructuredText formatting error. The file needs to be reformatted to pass the checks.
Run the RST formatter on this file to fix the formatting issues. The error message suggests the file can be auto-formatted. Typically, you can fix this by running the project's RST formatter or linter tool (check the repository's contributing guidelines for the specific command).
Common RST formatting issues include:
- Trailing whitespace
- Line length exceeding maximum limits
- Inconsistent indentation
#!/bin/bash # Description: Check for common RST formatting issues in the file echo "Checking for trailing whitespace:" cat content/blog/gsoc-25-whois-and-ip-geolocation.rst | grep -n " $" | head -20 echo -e "\nChecking for long lines (>79 characters):" awk 'length>79 {print NR": "length" chars"}' content/blog/gsoc-25-whois-and-ip-geolocation.rst | head -20 echo -e "\nNote: Run the project's RST formatter to auto-fix these issues."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@content/blog/gsoc-25-whois-and-ip-geolocation.rst` at line 1, The RST file titled "GSoC 2025: WHOIS Info and Estimated Geographic Locations" fails CI due to ReStructuredText formatting; run the repository's RST formatter (or the project's linter/pre-commit hook) on that file to remove trailing whitespace, wrap long lines to the project's max line length, and fix inconsistent indentation; specifically check for and remove trailing spaces, break lines over ~79 chars, and normalize section/title underline lengths so the document compiles cleanly, then re-run the CI or linter to verify the fix.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@content/blog/gsoc-25-whois-and-ip-geolocation.rst`:
- Line 1: The RST file titled "GSoC 2025: WHOIS Info and Estimated Geographic
Locations" fails CI due to ReStructuredText formatting; run the repository's RST
formatter (or the project's linter/pre-commit hook) on that file to remove
trailing whitespace, wrap long lines to the project's max line length, and fix
inconsistent indentation; specifically check for and remove trailing spaces,
break lines over ~79 chars, and normalize section/title underline lengths so the
document compiles cleanly, then re-run the CI or linter to verify the fix.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 282ba9ab-30b3-4028-aefc-51321ce1d9dc
📒 Files selected for processing (1)
content/blog/gsoc-25-whois-and-ip-geolocation.rst
📜 Review details
🧰 Additional context used
🪛 GitHub Actions: OpenWISP Website CI Build
content/blog/gsoc-25-whois-and-ip-geolocation.rst
[error] 1-1: ReStructuredText check failed. File could be reformatted.
🔇 Additional comments (2)
content/blog/gsoc-25-whois-and-ip-geolocation.rst (2)
175-179: Well done addressing the previous review feedback!The "Current state" section has been properly updated to reflect that the features are now merged and documented. This resolves the inconsistency that was flagged in the previous review where the narrative still referred to the work being on the
gsoc25-whoisbranch with pending PRs.The new text is concise, accurate, and includes the appropriate documentation links.
51-54: The documentation links using/docs/dev/paths are correct and appropriate. The stable documentation alternatives (/docs/stable/) do not exist for these features (return HTTP 404), meaning the development documentation is the only available reference. No changes are needed.
3d60ed8 to
acfdc77
Compare
Closes #110