Skip to content

Fix a potential XSS vulnerability on the hardcopy page. #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drgrice1 wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −5
Open

Fix a potential XSS vulnerability on the hardcopy page. #2849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/WeBWorK/ContentGenerator/Hardcopy.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ problem sets.

use File::Temp qw/tempdir/;
use Mojo::File;
use Mojo::Util qw(xml_escape);
use String::ShellQuote;
use Archive::Zip qw(:ERROR_CODES);
use XML::LibXML;
Expand Down Expand Up @@ -130,14 +131,16 @@ async sub pre_header_initialize ($c) {

# Make sure the format is valid.
unless (grep { $_ eq $hardcopy_format } keys %HC_FORMATS) {
$c->addbadmessage(qq{"$hardcopy_format" is not a valid hardcopy format.});
$c->addbadmessage($c->maketext('"[_1]" is not a valid hardcopy format.', xml_escape($hardcopy_format)));
$validation_failed = 1;
}

# Make sure we are allowed to generate hardcopy in this format.
unless ($authz->hasPermissions($userID, "download_hardcopy_format_$hardcopy_format")) {
$c->addbadmessage(
$c->maketext('You do not have permission to generate hardcopy in [_1] format.', $hardcopy_format));
$c->addbadmessage($c->maketext(
'You do not have permission to generate hardcopy in [_1] format.',
xml_escape($hardcopy_format)
));
$validation_failed = 1;
}

Expand Down Expand Up @@ -284,13 +287,14 @@ async sub pre_header_initialize ($c) {
my $fullFilePath = "$ce->{webworkDirs}{tmp}/$courseID/hardcopy/$userID/$tempFile";

unless (-e $fullFilePath) {
$c->addbadmessage($c->maketext('The requested file "[_1]" does not exist on the server.', $tempFile));
$c->addbadmessage(
$c->maketext('The requested file "[_1]" does not exist on the server.', xml_escape($tempFile)));
return;
}

unless ($baseName =~ /\.$userID\./ || $authz->hasPermissions($userID, 'download_hardcopy_multiuser')) {
$c->addbadmessage($c->maketext('You do not have permission to access the requested file "[_1]".'),
$tempFile);
xml_escape($tempFile));
return;
}

Expand Down