feat: return the id of the sent message from the remaining send methods - #179
Open
tarunvadde wants to merge 5 commits into
Open
feat: return the id of the sent message from the remaining send methods#179tarunvadde wants to merge 5 commits into
tarunvadde wants to merge 5 commits into
Conversation
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
genaris
approved these changes
Sep 10, 2026
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps that force callers past the Api and into the service.
calls,mrtdandshorten-urlalready return{ messageId }from every method that sends a message.receipts,reactions,user-profileandmedia-sharing.requestdid not, so the id of the message just sent was unreachable.requestUserProfilealso calledcreateRequestProfileMessage({}), dropping thequerythat the message class, the options type and the service all already support. Its siblingsendUserProfileforwardsthreadId, so the asymmetry sat inside one class.Nothing breaks for existing callers.
media-sharing.shareis left alone on purpose, it returns the DidCommMediaSharingRecord so changing its return would be breaking.