Skip to content

feat: return the id of the sent message from the remaining send methods - #179

Open
tarunvadde wants to merge 5 commits into
openwallet-foundation:mainfrom
tarunvadde:feat/return-sent-message-id
Open

feat: return the id of the sent message from the remaining send methods#179
tarunvadde wants to merge 5 commits into
openwallet-foundation:mainfrom
tarunvadde:feat/return-sent-message-id

Conversation

@tarunvadde

@tarunvadde tarunvadde commented Sep 9, 2026

Copy link
Copy Markdown

Two gaps that force callers past the Api and into the service.

calls, mrtd and shorten-url already return { messageId } from every method that sends a message. receipts, reactions, user-profile and media-sharing.request did not, so the id of the message just sent was unreachable.

requestUserProfile also called createRequestProfileMessage({}), dropping the query that the message class, the options type and the service all already support. Its sibling sendUserProfile forwards threadId, so the asymmetry sat inside one class.

Nothing breaks for existing callers. media-sharing.share is left alone on purpose, it returns the DidCommMediaSharingRecord so changing its return would be breaking.

Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants