-
Notifications
You must be signed in to change notification settings - Fork 74
feat: aot lightweight e1 rv32 mul, mulh, jalr #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
84ffea6 to
02d5c9f
Compare
CodSpeed Performance ReportMerging #2189 will degrade performances by 81.08%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|---|
| ⚡ | WallTime | benchmark_execute[bubblesort] |
27.4 ms | 8.1 ms | ×3.4 |
| ⚡ | WallTime | benchmark_execute[fibonacci_iterative] |
31.4 ms | 10.1 ms | ×3.1 |
| ⚡ | WallTime | benchmark_execute[fibonacci_recursive] |
45.1 ms | 12.1 ms | ×3.7 |
| ⚡ | WallTime | benchmark_execute[keccak256] |
33 ms | 9.7 ms | ×3.4 |
| ⚡ | WallTime | benchmark_execute[quicksort] |
32 ms | 9.7 ms | ×3.3 |
| ❌ | WallTime | benchmark_execute[revm_snailtracer] |
16.1 ms | 20.9 ms | -22.75% |
| ⚡ | WallTime | benchmark_execute[revm_transfer] |
43.1 ms | 26.5 ms | +62.54% |
| ⚡ | WallTime | benchmark_execute[sha256] |
31.1 ms | 8.1 ms | ×3.8 |
| ❌ | WallTime | benchmark_execute_metered[bubblesort] |
53 ms | 279.9 ms | -81.08% |
| ❌ | WallTime | benchmark_execute_metered[fibonacci_iterative] |
72.5 ms | 335.6 ms | -78.39% |
| ❌ | WallTime | benchmark_execute_metered[fibonacci_recursive] |
101.4 ms | 456.8 ms | -77.8% |
| ❌ | WallTime | benchmark_execute_metered[keccak256] |
68.9 ms | 303.3 ms | -77.28% |
| ❌ | WallTime | benchmark_execute_metered[pairing] |
156.1 ms | 247 ms | -36.82% |
| ❌ | WallTime | benchmark_execute_metered[quicksort] |
60.3 ms | 318.7 ms | -81.08% |
| ❌ | WallTime | benchmark_execute_metered[revm_snailtracer] |
17.1 ms | 20.1 ms | -15.1% |
| ❌ | WallTime | benchmark_execute_metered[revm_transfer] |
64.1 ms | 199 ms | -67.76% |
| ❌ | WallTime | benchmark_execute_metered[sha256] |
67.1 ms | 301.9 ms | -77.76% |
Footnotes
-
No successful run was found on
feat/aot(8256d66) during the generation of this report, somain(c2e376e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩ -
42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| } | ||
| #[cfg(feature = "aot")] | ||
| impl<F, A, const LIMB_BITS: usize> AotExecutor<F> | ||
| for BaseAluExecutor<A, { RV32_REGISTER_NUM_LIMBS }, LIMB_BITS> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? This will only cause more conlicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was originally needed for some of my tests, but I removed now that ALU is merged in. All other comments addressed as well: 62ab115
This reverts commit 5eff634.
72369e9 to
d891914
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 2b13a9a |
Closes INT-5263, INT-5262