Skip to content

Conversation

@Maillew
Copy link
Contributor

@Maillew Maillew commented Oct 30, 2025

Closes INT-5263, INT-5262

@Maillew Maillew changed the base branch from main to feat/aot-lightweight-E1-rv32 October 30, 2025 20:57
@Maillew Maillew self-assigned this Oct 30, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Maillew Maillew changed the title feat: aot lightweight e1 rv32 mul feat: aot lightweight e1 rv32 mul, mulh, jalr Oct 31, 2025
@github-actions

This comment has been minimized.

@Maillew Maillew marked this pull request as ready for review October 31, 2025 16:58
@Maillew Maillew changed the base branch from feat/aot-lightweight-E1-rv32 to feat/aot October 31, 2025 20:07
@Maillew Maillew changed the base branch from feat/aot to feat/aot-lightweight-E1-rv32 October 31, 2025 20:08
@nyunyunyunyu nyunyunyunyu force-pushed the feat/aot-lightweight-E1-rv32 branch from 84ffea6 to 02d5c9f Compare October 31, 2025 21:07
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #2189 will degrade performances by 81.08%

Comparing feat/aot-lightweight-E1-rv32-mul (2b13a9a) with main (c2e376e)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 7 improvements
❌ 10 regressions
✅ 1 untouched
⏩ 42 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime benchmark_execute[bubblesort] 27.4 ms 8.1 ms ×3.4
WallTime benchmark_execute[fibonacci_iterative] 31.4 ms 10.1 ms ×3.1
WallTime benchmark_execute[fibonacci_recursive] 45.1 ms 12.1 ms ×3.7
WallTime benchmark_execute[keccak256] 33 ms 9.7 ms ×3.4
WallTime benchmark_execute[quicksort] 32 ms 9.7 ms ×3.3
WallTime benchmark_execute[revm_snailtracer] 16.1 ms 20.9 ms -22.75%
WallTime benchmark_execute[revm_transfer] 43.1 ms 26.5 ms +62.54%
WallTime benchmark_execute[sha256] 31.1 ms 8.1 ms ×3.8
WallTime benchmark_execute_metered[bubblesort] 53 ms 279.9 ms -81.08%
WallTime benchmark_execute_metered[fibonacci_iterative] 72.5 ms 335.6 ms -78.39%
WallTime benchmark_execute_metered[fibonacci_recursive] 101.4 ms 456.8 ms -77.8%
WallTime benchmark_execute_metered[keccak256] 68.9 ms 303.3 ms -77.28%
WallTime benchmark_execute_metered[pairing] 156.1 ms 247 ms -36.82%
WallTime benchmark_execute_metered[quicksort] 60.3 ms 318.7 ms -81.08%
WallTime benchmark_execute_metered[revm_snailtracer] 17.1 ms 20.1 ms -15.1%
WallTime benchmark_execute_metered[revm_transfer] 64.1 ms 199 ms -67.76%
WallTime benchmark_execute_metered[sha256] 67.1 ms 301.9 ms -77.76%

Footnotes

  1. No successful run was found on feat/aot (8256d66) during the generation of this report, so main (c2e376e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Maillew Maillew changed the base branch from feat/aot-lightweight-E1-rv32 to feat/aot October 31, 2025 22:46
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

}
#[cfg(feature = "aot")]
impl<F, A, const LIMB_BITS: usize> AotExecutor<F>
for BaseAluExecutor<A, { RV32_REGISTER_NUM_LIMBS }, LIMB_BITS>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? This will only cause more conlicts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was originally needed for some of my tests, but I removed now that ALU is merged in. All other comments addressed as well: 62ab115

@Maillew Maillew force-pushed the feat/aot-lightweight-E1-rv32-mul branch from 72369e9 to d891914 Compare November 3, 2025 16:38
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 238 322,610 2,058,654 - - -
fibonacci 986 1,500,209 2,100,402 - - -
regex 2,319 4,137,502 17,695,216 - - -
ecrecover 735 122,859 2,263,820 - - -
pairing 1,413 1,745,742 25,468,210 - - -

Commit: 2b13a9a

Benchmark Workflow

@Maillew Maillew merged commit adb82aa into feat/aot Nov 3, 2025
51 of 57 checks passed
@Maillew Maillew deleted the feat/aot-lightweight-E1-rv32-mul branch November 3, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants