Skip to content

Fix data trapping in SDRAM #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix data trapping in SDRAM #15

wants to merge 3 commits into from

Conversation

@matwey
Copy link

@matwey matwey commented Aug 20, 2018

Close #13

matwey added 3 commits August 4, 2018 19:27
@matwey
Fix output build name
d651315 
Makefile expects to see ov3.bin but it is top.bin instead.
@matwey
Reset FIFO in sdram_sink and sdram_host_read
0ffe58f 
(cherry picked from commit eafc790)
@matwey
Return fifo_fsm to initial state when disabled
9000c41
@tmbinc tmbinc closed this Sep 7, 2018
@tmbinc tmbinc changed the base branch from tmbinc/new_migen to master September 7, 2018 21:58
@tmbinc tmbinc reopened this Sep 7, 2018
@tmbinc
Copy link
Collaborator

tmbinc commented Sep 7, 2018

For the record, my issue with this is that it makes stopping the data flow a data-loss event. We should have a proper reset, as opposed to clearing "go".

@matwey
Copy link
Author

matwey commented Sep 8, 2018

Any ideas what the 'proper reset' is?

@tmbinc
Copy link
Collaborator

tmbinc commented Sep 8, 2018

For example we could have a CSR bit that allows you to set a bit that will clear the data pipeline. @somehdlguy, any comments from your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matwey @tmbinc