Skip to content

Conversation

@blackencino
Copy link
Contributor

Part of #458

Summary

  • New src/fvdb/detail/dispatch/ module with dispatch-framework-aligned tools:
    • ForEachActiveVoxel.cuh — device-unified active-voxel iteration (built on dispatch::for_each)
    • GridAccessor.h — concept-constrained host/device accessor construction
    • JaggedView.hjagged_in view for jagged tensors (mirrors dispatch::tensor_in)
    • TensorChecks.h — precondition validation utilities
  • Ported 6 ops to dispatch_table + views (zero old macros):
    • ActiveGridGoordsforEachActiveVoxel + tensor_out
    • SerializeEncodeforEachActiveVoxel + tensor_out
    • MortonHilbertFromIjkdispatch::for_each + tensor_in/tensor_out
    • IjkToIndexdispatch::for_each + jagged_in + tensor_out (device x int stype x contiguity)
    • PointsInGriddispatch::for_each + jagged_in + tensor_out (device x float stype x contiguity)
  • Deleted SimpleOpHelper.h (all 3 consumers ported, -332 lines)
  • Removed FVDB_DISPATCH_KERNEL / FVDB_DISPATCH_KERNEL_DEVICE from 9 call sites in GridBatch.cpp and GridBatchImpl.cu
  • All op headers are now type-erased (no template <torch::DeviceType>)

Test plan

  • All 2218 unit tests pass (CPU + CUDA)
  • No old macros (FVDB_DISPATCH_KERNEL, AT_DISPATCH_V2) in any new/modified code
  • SimpleOpHelper.h has zero remaining includes

@blackencino blackencino requested a review from a team as a code owner February 11, 2026 05:36
@blackencino blackencino self-assigned this Feb 11, 2026
Signed-off-by: Christopher Horvath <[email protected]>
@blackencino blackencino requested review from fwilliams and removed request for sifakis February 11, 2026 05:42
Signed-off-by: Christopher Horvath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant