Skip to content

build: add black/clang-format helpers #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fwilliams wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: add black/clang-format helpers #449

fwilliams wants to merge 1 commit into from
+99 −26

Conversation

@fwilliams
Copy link
Collaborator

@fwilliams fwilliams commented Feb 6, 2026 •
edited
Loading

Summary

  • Add build.sh subcommands for CI-aligned Python (black) and C++/CUDA (clang-format) formatting.
  • Add scripts to run black and clang-format-18 (with helpful errors if missing).\n\n## Notes\n- Intended as a standalone formatting/tooling PR off main.

@fwilliams @cursoragent
build: add black/clang-format helpers
e52ec09 
Add build.sh subcommands to run CI-aligned black and clang-format, and add scripts that locate the expected formatter binaries.

Co-authored-by: Cursor <[email protected]>
@fwilliams fwilliams requested a review from a team as a code owner February 6, 2026 23:26
@fwilliams fwilliams mentioned this pull request Feb 10, 2026
Merged
5 tasks
@harrism
Copy link
Contributor

harrism commented Feb 10, 2026 •
edited
Loading

I think for black we can just add the command line arguments to pyproject.toml, no script needed. Then you can just call black. And it's easier to maintain than adding a build.sh to fvdb-reality-capture.

@harrism harrism added CI Issues related to the Github actions CI/CD. For build issues use CMake/Build cmake/build Issues related to building and CMake labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewdcong matthewdcong Awaiting requested review from matthewdcong matthewdcong is a code owner automatically assigned from openvdb/fvdb-dev

@phapalova phapalova Awaiting requested review from phapalova phapalova is a code owner automatically assigned from openvdb/fvdb-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CI Issues related to the Github actions CI/CD. For build issues use CMake/Build cmake/build Issues related to building and CMake

Projects

fvdb-realitycapture
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fwilliams @harrism