Conversation
|
cc: @ibraheem-abe |
README.md
Outdated
| git clone https://github.com/opentensor/subnet-template.git | ||
| cd subnet-template |
There was a problem hiding this comment.
I don't think this is what we want to do for a template.
There was a problem hiding this comment.
could you let me know what the idea is?
asking cause the readme walks through running the miner/validator logic defined in the repo but using the previous clone/change directory commands doesnt work.
There was a problem hiding this comment.
Well this is a template. So it's designed to be forked and the information in it updated by the forker. Having this hard-coded will work, and that's the problem. Because it works, people will think that's correct to do rather than updating the info to the fork.
There was a problem hiding this comment.
gotcha! i can edit the README so that it includes the forking of the repo and then change the command to reflect that.
does that work?
validator.py
Outdated
| for response in responses | ||
| if response is not None | ||
| ] | ||
| bt.logging.info(f"Successful responses: {successful_responses}") |
There was a problem hiding this comment.
It would be nice if we can also mention the index which corresponds to the uid of the responses.
For example, if the raw responses were: None, None, 3, None, 6
Instead of outputting simply 3, and 6, it will be nice to know the uids associated with them.
Helps easily identify which miner is responding
ibraheem-abe
left a comment
ibraheem-abe
left a comment
There was a problem hiding this comment.
@chideraao This looks good!
Can you resolve the conflicts before we can get this in?
PS: I was also thinking whether we should add information in the readme about networks (or atleast link to the docs).
So they know about the test network and how they can get test tao etc.
|
@ibraheem-abe that makes sense. will look into it and update the file. |
|
@ibraheem-abe I made changes to the PR to address the point you raised. kindly give another look when you can. |
3 participants
Updates to the Validator scoring logic and Readme