Skip to content

set base priority and nullify max_priority_fee_per_gas #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l0r1s wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set base priority and nullify max_priority_fee_per_gas #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frame/ethereum/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,8 @@ impl<T: Config> Pallet<T> {
// The tag provides and requires must be filled correctly according to the nonce.
let mut builder = ValidTransactionBuilder::default()
.and_provides((origin, transaction_nonce))
.priority(priority);
// basically EVM_TRANSACTION_BASE_PRIORITY: remove this once we have a proper way to set the priority
.priority(1);

// In the context of the pool, a transaction with
// too high a nonce is still considered valid
Expand Down
3 changes: 3 additions & 0 deletions frame/evm/src/runner/stack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ where
}
}

// TODO: remove this once we have a proper way to set the max_priority_fee_per_gas
let max_priority_fee_per_gas = None;

let total_fee_per_gas = if is_transactional {
match (max_fee_per_gas, max_priority_fee_per_gas) {
// Zero max_fee_per_gas for validated transactional calls exist in XCM -> EVM
Expand Down
Loading