Skip to content

Avoid Race Condition on SQLite Table Creation #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 2 commits into from
Feb 3, 2026
Merged

Avoid Race Condition on SQLite Table Creation #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f85b194
Ensures we await committing after creating the table but before addin…
thewhaleking Feb 3, 2026
37a9240
Move `_create_if_not_exists` to within the lock
thewhaleking Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion async_substrate_interface/async_substrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,7 +2001,6 @@ async def result_handler(

if subscription_result is not None:
reached = True
logger.info("REACHED!")
# Handler returned end result: unsubscribe from further updates
async with self.ws as ws:
await ws.unsubscribe(
Expand Down
5 changes: 3 additions & 2 deletions async_substrate_interface/utils/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ async def _create_if_not_exists(self, chain: str, table_name: str):
);
"""
)
await self._db.commit()
await self._db.execute(
f"""
CREATE TRIGGER IF NOT EXISTS prune_rows_trigger_{table_name} AFTER INSERT ON {table_name}
Expand All @@ -82,8 +83,8 @@ async def __call__(self, chain, other_self, func, args, kwargs) -> Optional[Any]
if not self._db:
_ensure_dir()
self._db = await aiosqlite.connect(CACHE_LOCATION)
table_name = _get_table_name(func)
local_chain = await self._create_if_not_exists(chain, table_name)
table_name = _get_table_name(func)
local_chain = await self._create_if_not_exists(chain, table_name)
key = pickle.dumps((args, kwargs or None))
try:
cursor: aiosqlite.Cursor = await self._db.execute(
Expand Down