Skip to content

Conversation

@Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Oct 28, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Fixed issues contained in this release
Move the add button for repeated groups from top to bottom
Translation is not coming in validation dialog after submission of the Questionnaire
InitialExpression with result of type Coding should ignore display
Migrate Review Recyclerview to Compose
Migrate EditTextViewHolderFactory to compose

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Oct 28, 2025
@Rkareko Rkareko marked this pull request as draft October 29, 2025 09:14
@Rkareko Rkareko changed the title Bump up SDC library version Update Android FHIR SDK library versions Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 8.65385% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.5%. Comparing base (aaebbb6) to head (012ce4d).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 6.5% 57 Missing ⚠️
.../sdc/qrCode/EditTextQrCodeItemViewHolderFactory.kt 9.3% 29 Missing ⚠️
...re/engine/util/extension/QuestionnaireExtension.kt 0.0% 4 Missing ⚠️
...quest/ui/sdc/password/PasswordViewHolderFactory.kt 0.0% 3 Missing ⚠️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3804     +/-   ##
=========================================
- Coverage     25.0%   24.5%   -0.6%     
- Complexity     844     849      +5     
=========================================
  Files          297     303      +6     
  Lines        16102   16522    +420     
  Branches      2689    2762     +73     
=========================================
+ Hits          4038    4060     +22     
- Misses       11580   11979    +399     
+ Partials       484     483      -1     
Flag Coverage Δ
engine 60.7% <0.0%> (-0.3%) ⬇️
geowidget 21.7% <ø> (+3.1%) ⬆️
quest 4.5% <9.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t/ui/sdc/qrCode/EditTextQrCodeViewHolderFactory.kt 17.1% <100.0%> (ø)
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.6% <0.0%> (-0.1%) ⬇️
...quest/ui/sdc/password/PasswordViewHolderFactory.kt 0.0% <0.0%> (ø)
...re/engine/util/extension/QuestionnaireExtension.kt 54.4% <0.0%> (-1.8%) ⬇️
.../sdc/qrCode/EditTextQrCodeItemViewHolderFactory.kt 7.1% <9.3%> (-2.0%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 5.8% <6.5%> (+0.4%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rkareko Rkareko requested review from LZRS and ndegwamartin October 30, 2025 06:02
@Rkareko Rkareko marked this pull request as ready for review October 30, 2025 09:44
Copy link
Member

@FikriMilano FikriMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the textbox's question text and spacing is a bit broken when using this snapshot.
we'll need to investigate.

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants