Skip to content

Conversation

@FikriMilano
Copy link
Member

IMPORTANT: Where possible all PRs must be linked to a Github issue

Register has that default divider at the bottom, configure whether to display that or not.

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.5%. Comparing base (a790c9d) to head (a8ccb67).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3678     +/-   ##
=========================================
- Coverage     38.6%   38.5%   -0.1%     
+ Complexity    1168    1144     -24     
=========================================
  Files          286     285      -1     
  Lines        15291   15070    -221     
  Branches      2697    2665     -32     
=========================================
- Hits          5907    5811     -96     
+ Misses        8536    8436    -100     
+ Partials       848     823     -25     
Flag Coverage Δ
engine 60.8% <ø> (-2.1%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/quest/ui/register/components/RegisterCardList.kt 0.0% <ø> (ø)

... and 24 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants