Use internal registry image for executor artifact sidecar

[smarthall]

Summary

• Replace busybox:latest with the internal OpenShift CLI image (image-registry.openshift-image-registry.svc:5000/openshift/cli:latest) for the pause-for-artifacts sidecar container in the ad-hoc test executor
• The busybox:latest pull from Docker Hub is subject to rate limits and transient 503 errors, which caused a race condition where the sidecar hadn't started by the time artifact collection was attempted after a fast-completing test
• The internal CLI image is already used elsewhere in the codebase (pkg/e2e/osd/rebalance_infra_nodes.go) and is pre-cached on cluster nodes

Test plan

• Verify the pause-for-artifacts container starts reliably in ad-hoc test executor jobs
• Confirm artifact collection succeeds for fast-completing test suites
• Run periodic-ci-openshift-osde2e-main-nightly-4.21-osd-aws and verify no container not found errors

🤖 Generated with Claude Code

[openshift-ci-robot]

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4fcaedb8-c02e-4668-8ddc-0162ea5504b1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smarthall
Once this PR has been reviewed and has the lgtm label, please assign christophermancini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ritmun]

you're going to get errors if image-registry is down. Would you rather defer to busybox erroring out on image pull, or have to troubleshoot ocp image registry not being up. So now instead of focusing on the specific e2e tests you are entangled in registry issues. I don't know how I feel about this.

Mind that we use this for specific compoentn's piepliens, and they assume cluster health.

[smarthall]

I made this PR as there were issues with the tests receiving errors when pulling from the docker registry, and because of this the output and artifacts of a test was being lost.

I chose this image as it is already used elsewhere in the tests, so I presumed that this wasn't a concern. If that's not the case we might need to address that existing code too.

I feel that depending on the ocp image registry is the more reliable option then depending on a third party registry. However the other containers in the pods pull from quay, would you be more comfortable with a ubi-minimal image from quay or the red hat registry? Would you like me to update the image used for the rebalancing tests too?