fix cleanup command polling issue#3181
fix cleanup command polling issue#3181varunraokadaparthi wants to merge 1 commit intoopenshift:mainfrom
Conversation
varunraokadaparthi
commented
Mar 27, 2026
- The cleanup command currently waits up to 15 minutes when the cluster is in an error state. It should instead immediately proceed with deletion without waiting.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| err = o.AddProperty(cluster, clusterproperties.Status, clusterproperties.StatusUninstalling) | ||
| if err != nil { | ||
| return fmt.Errorf("error adding uninstalling status to cluster: %v", err) | ||
| if cluster.State() == spi.ClusterStatePending { |
There was a problem hiding this comment.
What about clusters that are in the Installing state?