-
Notifications
You must be signed in to change notification settings - Fork 14
NO-JIRA: Adding a first claude slash command for syncing downstream with upstream #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@matzew: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @Cali0707 |
|
/hold the outcome is a bit odd :) |
Signed-off-by: Matthias Wessendorf <[email protected]>
128a0c3 to
e45ed9c
Compare
|
/unhold tweaked it to use detached HEAD, and it got the same diff, than my manual script |
|
@matzew: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Cali0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks fine as a claude command to me. Tbh I'm not 100% sure this is the best scenario to use a cluade command in, and that may be influencing the comment I left.
However, I also don't mind having a claude command so I'm happy if this goes in
|
|
||
| ```bash | ||
| # 1. Start from detached HEAD (REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to move all of this into a script, and just tell claude to use that script/make target?
I feel like that could be more general - then claude users can do a sync with claude and non-claude users can do one manually if they want
As per title.
Experimenting with claude, and adding a "slash command" for the downstream sync.
Not sure if that's a great win over something like this "script":
But Claude is being a good assistant