Skip to content

Conversation

@matzew
Copy link
Member

@matzew matzew commented Nov 14, 2025

As per title.

Experimenting with claude, and adding a "slash command" for the downstream sync.

Not sure if that's a great win over something like this "script":

  # Create the sync-downstream branch and merge WITHOUT committing
  git fetch downstream
  git fetch upstream
  git checkout -b sync-downstream upstream/main
  git merge -s ours --no-commit downstream/main

  # Now, use `git checkout` to grab the specific files/folders
  git checkout downstream/main -- .ci-operator.yaml
  git checkout downstream/main -- .snyk
  git checkout downstream/main -- .tekton/
  git checkout downstream/main -- Dockerfile.ci
  git checkout downstream/main -- Dockerfile.ocp
  git checkout downstream/main -- Makefile-ocp.mk
  git checkout downstream/main -- OWNERS
  git checkout downstream/main -- mcp_config.toml
  git checkout downstream/main -- renovate.json

  # Update vendored dependencies
  go mod tidy
  go mod vendor
  git add vendor/

  # Commit EVERYTHING in ONE commit (including the merge)
  git commit -am "sync: merge upstream main with downstream config"

But Claude is being a good assistant

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2025
@openshift-ci-robot
Copy link

@matzew: This pull request explicitly references no jira issue.

In response to this:

As per title.

Experimenting with claude, and adding a "slash command" for the downstream sync.

Not sure if that's a great win over something like this "script":

 # Create the sync-downstream branch and merge WITHOUT committing
 git fetch downstream
 git fetch upstream
 git checkout -b sync-downstream upstream/main
 git merge -s ours --no-commit downstream/main

 # Now, use `git checkout` to grab the specific files/folders
 git checkout downstream/main -- .ci-operator.yaml
 git checkout downstream/main -- .snyk
 git checkout downstream/main -- .tekton/
 git checkout downstream/main -- Dockerfile.ci
 git checkout downstream/main -- Dockerfile.ocp
 git checkout downstream/main -- Makefile-ocp.mk
 git checkout downstream/main -- OWNERS
 git checkout downstream/main -- mcp_config.toml
 git checkout downstream/main -- renovate.json

 # Update vendored dependencies
 go mod tidy
 go mod vendor
 git add vendor/

 # Commit EVERYTHING in ONE commit (including the merge)
 git commit -am "sync: merge upstream main with downstream config"

But Claude is being a good assistant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2025
@matzew
Copy link
Member Author

matzew commented Nov 14, 2025

/assign @Cali0707

@matzew
Copy link
Member Author

matzew commented Nov 14, 2025

/hold

the outcome is a bit odd :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025
@matzew matzew force-pushed the sync_downstream_command branch from 128a0c3 to e45ed9c Compare November 14, 2025 08:31
@matzew
Copy link
Member Author

matzew commented Nov 14, 2025

/unhold

tweaked it to use detached HEAD, and it got the same diff, than my manual script

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 14, 2025

@matzew: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine as a claude command to me. Tbh I'm not 100% sure this is the best scenario to use a cluade command in, and that may be influencing the comment I left.

However, I also don't mind having a claude command so I'm happy if this goes in

Comment on lines +17 to +19

```bash
# 1. Start from detached HEAD (REQUIRED)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move all of this into a script, and just tell claude to use that script/make target?

I feel like that could be more general - then claude users can do a sync with claude and non-claude users can do one manually if they want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants