Skip to content

WIP OU-1271: Upgrade to ReactRouterV6Adapter#852

Open
zhuje wants to merge 1 commit intoopenshift:mainfrom
zhuje:ou1271-react-router-upgrade
Open

WIP OU-1271: Upgrade to ReactRouterV6Adapter#852
zhuje wants to merge 1 commit intoopenshift:mainfrom
zhuje:ou1271-react-router-upgrade

Conversation

@zhuje
Copy link
Contributor

@zhuje zhuje commented Mar 16, 2026 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2026 •
edited by openshift-ci bot
Loading

@zhuje: This pull request references OU-1271 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from etmurasaki and jgbernalp March 16, 2026 21:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026
@zhuje
Copy link
Contributor Author

zhuje commented Mar 16, 2026 •
edited
Loading 

package.json (2 errors)
    Console provides shared module react-router-dom 5.3.x but plugin uses version 6.30.3
    Console provides shared module redux ^4.0.4 but plugin uses version 4.0.1

Upgrade to ReactRouterV6Adapter will probably require the breaking changes we have scheduled for Sprint 286 and 287 (e.g. redux, react, and openshift-sdk upgrades)...

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2026 •
edited by openshift-ci bot
Loading

@zhuje: This pull request references OU-1271 which is a valid jira issue.

Details

In response to this:

JIRA
https://redhat.atlassian.net/browse/OU-1271

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jgbernalp
jgbernalp reviewed Mar 17, 2026
View reviewed changes
web/package-lock.json
"react": ">=15"
}
},
"node_modules/@openshift-console/dynamic-plugin-sdk/node_modules/react-router-dom-v5-compat": {
Copy link
Contributor

@jgbernalp jgbernalp Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need this. We need to check the uninstallation process.

jgbernalp
jgbernalp reviewed Mar 17, 2026
View reviewed changes
web/package.json
"react-modal": "^3.12.1",
"react-redux": "7.2.9",
"react-router-dom-v5-compat": "^6.30.0",
"react-router-dom": "^6.30.0",
Copy link
Contributor

@jgbernalp jgbernalp Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest 6.x version of react-router-dom is 6.30.3

jgbernalp
jgbernalp reviewed Mar 17, 2026
View reviewed changes
web/src/components/dashboards/perses/dashboard-page.tsx

const DashboardPage_: FC = () => {
const { t } = useTranslation(process.env.I18N_NAMESPACE);
const [searchParams] = useSearchParams();
Copy link
Contributor

@jgbernalp jgbernalp Mar 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still use useSearchParams in react router 6: https://reactrouter.com/6.30.3/hooks/use-search-params

@jgbernalp
Copy link
Contributor

jgbernalp commented Mar 17, 2026

We need to find the usages of useHistory and replace with useNavigate https://reactrouter.com/6.30.3/upgrading/v5#use-usenavigate-instead-of-usehistory

@jgbernalp
Copy link
Contributor

jgbernalp commented Mar 17, 2026 

package.json (2 errors)
    Console provides shared module react-router-dom 5.3.x but plugin uses version 6.30.3
    Console provides shared module redux ^4.0.4 but plugin uses version 4.0.1

Upgrade to ReactRouterV6Adapter will probably require the breaking changes we have scheduled for Sprint 286 and 287 (e.g. redux, react, and openshift-sdk upgrades)...

We probably need to update the SDK version

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@zhuje: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images dda7a15 link true /test okd-scos-images
ci/prow/e2e-aws-ovn dda7a15 link true /test e2e-aws-ovn
ci/prow/periodics-images dda7a15 link true /test periodics-images
ci/prow/images dda7a15 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbernalp jgbernalp jgbernalp left review comments

@etmurasaki etmurasaki Awaiting requested review from etmurasaki

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhuje @openshift-ci-robot @jgbernalp