Skip to content

DO NOT MERGE: Test pr-check catches resource drift#486

Closed
reedcort wants to merge 1 commit intoopenshift:masterfrom
reedcort:test-prow-pr-check
Closed

DO NOT MERGE: Test pr-check catches resource drift#486
reedcort wants to merge 1 commit intoopenshift:masterfrom
reedcort:test-prow-pr-check

Conversation

@reedcort
Copy link
Copy Markdown
Contributor

Test PR to verify the new Prow pr-check job catches stale generated resources.

This changes the SCC webhook timeout without regenerating syncset/package resources. The pr-check should fail with "unexpected changes after building".

Will be closed after verification.

@openshift-ci openshift-ci bot requested review from Mhodesty and bmeng March 31, 2026 16:59
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reedcort
Once this PR has been reviewed and has the lgtm label, please assign bng0y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9a13ba9d-af20-4d63-88c2-d89700a6cf8a

📥 Commits

Reviewing files that changed from the base of the PR and between 4c87973 and 2071f55.

📒 Files selected for processing (1)
  • pkg/webhooks/scc/scc.go

Walkthrough

The webhook's configured timeout for SCC was increased from 2 to 3 seconds by updating the timeout variable in the SCC webhook configuration. No logic, control flow, or method signatures were modified.

Changes

Cohort / File(s) Summary
SCC Webhook Timeout
pkg/webhooks/scc/scc.go
Updated timeout variable from 2 to 3 seconds used by TimeoutSeconds() method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@reedcort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pr-check 2071f55 link true /test pr-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@reedcort reedcort closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant