OCPBUGS-74513: OCPBUGS-74519: Remove MachineConfigNodes and PinnedImages feature gates#5609
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
/test verify |
2 similar comments
|
/test verify |
|
/test verify |
|
/test unit |
|
/test all |
isabella-janssen
force-pushed
the
ocpbugs-74513
branch
2 times, most recently
from
5195a81 to
33ba2a8
Compare
|
/test all |
|
/test verify |
|
/test unit |
|
/test all |
isabella-janssen
changed the title
MachineConfigNodes and PinnedImages feature gates
openshift-ci-robot
added
jira/valid-reference
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74513, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 openshift/api#2715 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6aa05d40-0c44-11f1-9ce4-4d5ce96c4ea8-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 openshift/api#2715 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/843dfb40-0c44-11f1-9e48-755722ba80a8-0 |
isabella-janssen
force-pushed
the
ocpbugs-74513
branch
3 times, most recently
from
8b43933 to
d8a2367
Compare
isabella-janssen
force-pushed
the
ocpbugs-74513
branch
from
d8a2367 to
03fb53a
Compare
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74513, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
Looks like a clean change. Test failures seem unrelated
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload blocking |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b6943720-1708-11f1-8a4f-fae831f07fb3-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-2of2 |
|
@isabella-janssen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6546f690-1709-11f1-9977-63f3a5c9aa63-0 |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea31aab0-18a5-11f1-9f16-e57907b582b5-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-1of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-2of3 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-3of3 |
|
@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f30cd150-18a5-11f1-95cf-ad6a6cb75868-0 |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07e6ac40-18d3-11f1-852e-1f49fed94531-0 |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/70ea78e0-1962-11f1-962a-0a42f9cf956d-0 |
|
/payload 4.22 nightly blocking |
|
@isabella-janssen: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7e563410-1be7-11f1-906e-b2ca1e55fa2c-0 |
|
Pre-merge tested Environment Setup: Verified against existing e2e MCN and PIS TC have passed /label qe-approved |
openshift-ci-robot
added
the
verified
|
@ptalgulk01: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
qe-approved
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74513, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-hypershift The hypershift test passed previously on the latest commit (see here) and is generally flakey, so I'm overriding it. |
|
@isabella-janssen: Overrode contexts on behalf of isabella-janssen: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@isabella-janssen: Jira Issue OCPBUGS-74513: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-74513 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
- What I did
Remove references to the
MachineConfigNodesandPinnedImagesfeature gates throughout the MCO code.- How to verify it
All existing tests and functionality should continue passing & there should be no references to the
MachineConfigNodesandPinnedImagesfeature gates.- Description for the changelog
OCPBUGS-74513 & OCPBUGS-74519: Remove MCO references to the
MachineConfigNodesandPinnedImagesfeature gates