Skip to content

OCPBUGS-67308: High numbers of segment events don't have a release version #16121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Leo6Leo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

OCPBUGS-67308: High numbers of segment events don't have a release version #16121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/packages/console-dynamic-plugin-sdk/src/api/segment-analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,21 @@ const TELEMETRY_JS_URL =
TELEMETRY_API_KEY,
)}/analytics.min.js`;

const CONSOLE_VERSION =
window.SERVER_FLAGS.releaseVersion || window.SERVER_FLAGS.consoleVersion || '';
const IS_CI_ENVIRONMENT = /test-ci|ci-ln-|nightly/i.test(CONSOLE_VERSION);

export const TELEMETRY_DISABLED =
!TELEMETRY_API_KEY ||
IS_CI_ENVIRONMENT ||
window.SERVER_FLAGS.telemetry?.DISABLED === 'true' ||
window.SERVER_FLAGS.telemetry?.DEVSANDBOX_DISABLED === 'true' ||
window.SERVER_FLAGS.telemetry?.TELEMETER_CLIENT_DISABLED === 'true';

export const TELEMETRY_DEBUG = window.SERVER_FLAGS.telemetry?.DEBUG === 'true';

// Sample 20% of sessions
const SAMPLE_SESSION = Math.random() < 0.2;
// Sample 10% of sessions
const SAMPLE_SESSION = Math.random() < 0.1;

// TODO: replace this copy-pasted Segment init snippet with proper use of Segment package
// https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/quickstart/#step-2-install-segment-to-your-site
Expand Down Expand Up @@ -106,7 +111,6 @@ const initSegmentAnalytics = () => {
options.integrations = { 'Segment.io': { apiHost: TELEMETRY_API_HOST } };
}
analytics.load(TELEMETRY_API_KEY, options);
analytics.page(); // Make the first page call to load the integrations
};

if (!SAMPLE_SESSION) {
Expand Down