Skip to content

[WIP] CONSOLE-5065: Clean up Console extension code reference processing#16115

Open
vojtechszocs wants to merge 3 commits intoopenshift:mainfrom
vojtechszocs:cleanup-code-ref-processing
Open

[WIP] CONSOLE-5065: Clean up Console extension code reference processing#16115
vojtechszocs wants to merge 3 commits intoopenshift:mainfrom
vojtechszocs:cleanup-code-ref-processing

Conversation

@vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Mar 6, 2026

Work In Progress

Follow-up to #15904 as part of CONSOLE-5065

Depends on openshift/dynamic-plugin-sdk#310

  • Modify useResolvedExtensions to use equivalent upstream plugin SDK hook
  • Ensure proper type signature of useResolvedExtensions hook
    • ⚠️ breaking change - this hook now supports a single predicate parameter
  • Reuse code reference utilities from @openshift/dynamic-plugin-sdk
  • Add upstream plugin SDK packages to Yarn npmPreapprovedPackages
    • @openshift/dynamic-plugin-sdk
    • @openshift/dynamic-plugin-sdk-webpack

Note 📝 changes from #10421 are not included - it's not clear whether the bug was due to Console specific code reference resolution code or due to 3rd party dependencies such as webpack generated code.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2026
@openshift-ci openshift-ci bot requested review from cajieh and jhadvig March 6, 2026 18:30
@openshift-ci openshift-ci bot added component/sdk Related to console-plugin-sdk component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. plugin-api-changed Categorizes a PR as containing plugin API changes labels Mar 6, 2026
},
"dependencies": {
"@openshift/dynamic-plugin-sdk": "^8.0.0",
"@openshift/dynamic-plugin-sdk": "file:../../dynamic-plugin-sdk/packages/lib-core",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@vojtechszocs vojtechszocs changed the title WIP: Clean up Console extension code reference processing [WIP]: Clean up Console extension code reference processing Mar 6, 2026
@vojtechszocs vojtechszocs force-pushed the cleanup-code-ref-processing branch from 859e8e3 to febca81 Compare March 6, 2026 18:54
@openshift-ci openshift-ci bot added the kind/demo-plugin Related to dynamic-demo-plugin label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff logonoff force-pushed the cleanup-code-ref-processing branch 4 times, most recently from 1c189e1 to 3818c63 Compare March 6, 2026 21:38
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2026
@logonoff logonoff force-pushed the cleanup-code-ref-processing branch from 3818c63 to c43eb11 Compare March 10, 2026 14:15
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Mar 10, 2026
@logonoff logonoff force-pushed the cleanup-code-ref-processing branch from c43eb11 to 19f6471 Compare March 10, 2026 14:16
@logonoff
Copy link
Member

logonoff commented Mar 10, 2026

/retitle [WIP] CONSOLE-5065: Clean up Console extension code reference processing

@openshift-ci openshift-ci bot changed the title [WIP]: Clean up Console extension code reference processing [WIP] CONSOLE-5065: Clean up Console extension code reference processing Mar 10, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 10, 2026

@vojtechszocs: This pull request references CONSOLE-5065 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Work In Progress

Follow-up to #15904 as part of CONSOLE-5065

Depends on openshift/dynamic-plugin-sdk#310

  • Modify useResolvedExtensions to use equivalent upstream plugin SDK hook
  • Ensure proper type signature of useResolvedExtensions hook
  • ⚠️ breaking change - this hook now supports a single predicate parameter
  • Reuse code reference utilities from @openshift/dynamic-plugin-sdk
  • Add upstream plugin SDK packages to Yarn npmPreapprovedPackages
  • @openshift/dynamic-plugin-sdk
  • @openshift/dynamic-plugin-sdk-webpack

Note 📝 changes from #10421 are not included - it's not clear whether the bug was due to Console specific code reference resolution code or due to 3rd party dependencies such as webpack generated code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2026
@logonoff
Copy link
Member

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 10, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2026

@vojtechszocs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 19f6471 link true /test frontend
ci/prow/e2e-gcp-console 19f6471 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/sdk Related to console-plugin-sdk component/shared Related to console-shared do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/demo-plugin Related to dynamic-demo-plugin plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants