OPRUN-4502: Add feature-gate for DeploymentConfig#176
OPRUN-4502: Add feature-gate for DeploymentConfig#176openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
Conversation
Signed-off-by: Todd Short <todd.short@me.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
Expected to fail until the other PRs are merged. |
|
/assign @kuiwang02 |
|
/retest |
|
Depends on openshift/client-go#365 in order to pull in latest openshift/api@main |
Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
add-config-api-feature-gate
branch
from
6501a70 to
519be18
Compare
tmshort
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@tmshort: This pull request references OPRUN-4502 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
add-config-api-feature-gate
branch
from
10134c2 to
8cc8912
Compare
|
/test openshift-e2e-aws-customnoupgrade |
|
with kuiwang@kuiwang-mac ~ % oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.22.0-0-2026-03-18-004713-test-ci-ln-0dyi3wk-latest True False 129m Cluster version is 4.22.0-0-2026-03-18-004713-test-ci-ln-0dyi3wk-latest
kuiwang@kuiwang-mac ~ % oc get featuregate -o yaml
apiVersion: v1
items:
- apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
creationTimestamp: "2026-03-18T01:04:57Z"
generation: 2
name: cluster
resourceVersion: "53490"
uid: 2b6feb41-8c9e-452b-9440-d1c5cb4edf00
spec:
featureSet: TechPreviewNoUpgrade
status:
featureGates:
- disabled:
- name: ClientsAllowCBOR
- name: ClusterAPIComputeInstall
- name: ClusterAPIControlPlaneInstall
- name: ClusterAPIInstall
- name: ClusterUpdatePreflight
- name: EventedPLEG
- name: Example2
- name: ExternalOIDCExternalClaimsSourcing
- name: ExternalSnapshotMetadata
- name: HyperShiftOnlyDynamicResourceAllocation
- name: KMSEncryptionProvider
- name: MachineAPIMigrationVSphere
- name: MachineAPIOperatorDisableMachineHealthCheckController
- name: MultiArchInstallAzure
- name: NetworkConnect
- name: ProvisioningRequestAvailable
- name: ShortCertRotation
enabled:
- name: AWSClusterHostedDNS
- name: AWSClusterHostedDNSInstall
- name: AWSDedicatedHosts
- name: AWSDualStackInstall
- name: AWSEuropeanSovereignCloudInstall
- name: AWSServiceLBNetworkSecurityGroup
- name: AdditionalStorageConfig
- name: AutomatedEtcdBackup
- name: AzureClusterHostedDNSInstall
- name: AzureDedicatedHosts
- name: AzureDualStackInstall
- name: AzureMultiDisk
- name: AzureWorkloadIdentity
- name: BootImageSkewEnforcement
- name: BootcNodeManagement
- name: BuildCSIVolumes
- name: CBORServingAndStorage
- name: CRDCompatibilityRequirementOperator
- name: CRIOCredentialProviderConfig
- name: ClientsPreferCBOR
- name: ClusterAPIInstallIBMCloud
- name: ClusterAPIMachineManagement
- name: ClusterAPIMachineManagementAWS
- name: ClusterAPIMachineManagementAzure
- name: ClusterAPIMachineManagementBareMetal
- name: ClusterAPIMachineManagementGCP
- name: ClusterAPIMachineManagementOpenStack
- name: ClusterAPIMachineManagementPowerVS
- name: ClusterAPIMachineManagementVSphere
- name: ClusterMonitoringConfig
- name: ClusterUpdateAcceptRisks
- name: ClusterVersionOperatorConfiguration
- name: ConfigurablePKI
- name: ConsolePluginContentSecurityPolicy
- name: DNSNameResolver
- name: DRAPartitionableDevices
- name: DualReplica
- name: DyanmicServiceEndpointIBMCloud
- name: EVPN
- name: EtcdBackendQuota
- name: EventTTL
- name: Example
- name: ExternalOIDC
- name: ExternalOIDCWithUIDAndExtraClaimMappings
- name: ExternalOIDCWithUpstreamParity
- name: GCPClusterHostedDNS
- name: GCPClusterHostedDNSInstall
- name: GCPCustomAPIEndpoints
- name: GCPCustomAPIEndpointsInstall
- name: GCPDualStackInstall
- name: GatewayAPIWithoutOLM
- name: HighlyAvailableArbiter
- name: ImageModeStatusReporting
- name: ImageStreamImportMode
- name: IngressControllerDynamicConfigurationManager
- name: InsightsConfig
- name: InsightsOnDemandDataGather
- name: IrreconcilableMachineConfig
- name: KMSEncryption
- name: KMSv1
- name: MachineAPIMigration
- name: MachineAPIMigrationAWS
- name: MachineAPIMigrationOpenStack
- name: ManagedBootImagesCPMS
- name: MaxUnavailableStatefulSet
- name: MetricsCollectionProfiles
- name: MinimumKubeletVersion
- name: MixedCPUsAllocation
- name: MultiDiskSetup
- name: MutableCSINodeAllocatableCount
- name: MutatingAdmissionPolicy
- name: NewOLM
- name: NewOLMBoxCutterRuntime
- name: NewOLMCatalogdAPIV1Metas
- name: NewOLMOwnSingleNamespace
- name: NewOLMPreflightPermissionChecks
- name: NewOLMWebhookProviderOpenshiftServiceCA
- name: NoRegistryClusterInstall
- name: NutanixMultiSubnets
- name: OSStreams
- name: OVNObservability
- name: OnPremDNSRecords
- name: OpenShiftPodSecurityAdmission
- name: RouteExternalCertificate
- name: SELinuxMount
- name: ServiceAccountTokenNodeBinding
- name: SignatureStores
- name: SigstoreImageVerification
- name: SigstoreImageVerificationPKI
- name: StoragePerformantSecurityPolicy
- name: UpgradeStatus
- name: UserNamespacesPodSecurityStandards
- name: UserNamespacesSupport
- name: VSphereConfigurableMaxAllowedBlockVolumesPerNode
- name: VSphereHostVMGroupZonal
- name: VSphereMixedNodeEnv
- name: VSphereMultiDisk
- name: VSphereMultiNetworks
- name: VolumeGroupSnapshot
version: 4.22.0-0-2026-03-18-004713-test-ci-ln-0dyi3wk-latest
kind: List
metadata:
resourceVersion: ""
oc -n openshift-operator-controller get pod -o yaml
apiVersion: v1
items:
- apiVersion: v1
kind: Pod
metadata:
annotations:
k8s.ovn.org/pod-networks: '{"default":{"ip_addresses":["10.129.0.35/23"],"mac_address":"0a:58:0a:81:00:23","gateway_ips":["10.129.0.1"],"routes":[{"dest":"10.128.0.0/14","nextHop":"10.129.0.1"},{"dest":"172.30.0.0/16","nextHop":"10.129.0.1"},{"dest":"169.254.0.5/32","nextHop":"10.129.0.1"},{"dest":"100.64.0.0/16","nextHop":"10.129.0.1"}],"ip_address":"10.129.0.35/23","gateway_ip":"10.129.0.1","role":"primary"}}'
k8s.v1.cni.cncf.io/network-status: |-
[{
"name": "ovn-kubernetes",
"interface": "eth0",
"ips": [
"10.129.0.35"
],
"mac": "0a:58:0a:81:00:23",
"default": true,
"dns": {}
}]
kubectl.kubernetes.io/default-container: manager
olm.operatorframework.io/feature-set: experimental
openshift.io/required-scc: privileged
openshift.io/scc: privileged
seccomp.security.alpha.kubernetes.io/pod: runtime/default
security.openshift.io/validated-scc-subject-type: serviceaccount
creationTimestamp: "2026-03-18T03:25:12Z"
generateName: operator-controller-controller-manager-546766b8d-
generation: 1
labels:
app.kubernetes.io/name: operator-controller
app.kubernetes.io/part-of: olm
control-plane: operator-controller-controller-manager
pod-template-hash: 546766b8d
topology.kubernetes.io/region: us-east-1
topology.kubernetes.io/zone: us-east-1a
name: operator-controller-controller-manager-546766b8d-g42ks
namespace: openshift-operator-controller
...
containers:
- args:
- --health-probe-bind-address=:8081
- --metrics-bind-address=:8443
- --leader-elect
- --feature-gates=BoxcutterRuntime=true
- --feature-gates=PreflightPermissions=true
- --feature-gates=SingleOwnNamespaceInstallSupport=true
- --feature-gates=WebhookProviderOpenshiftServiceCA=true
- --feature-gates=DeploymentConfig=false
- --feature-gates=HelmChartSupport=false
- --feature-gates=WebhookProviderCertManager=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
... |
|
@kuiwang02 it appears that the openshift/api change has not been propagated everywhere it needs to go: And because the gate from that PR is not in either list ( |
|
The ci/prow/openshift-e2e-aws-customnoupgrade test is failing on other PRs as well; so I'm not concerned about it. |
|
@kuiwang02 the gate is available in 4.23.0-0.ci-2026-03-18-173602 |
|
/verified by @kuiwang02 |
openshift-ci-robot
added
the
verified
|
@kuiwang02: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
@CodeRabbit configuration |
|
Configuration used: Organization UI CodeRabbit configurationlanguage: en-US
tone_instructions: ''
early_access: false
enable_free_tier: true
inheritance: true
reviews:
profile: chill
request_changes_workflow: false
high_level_summary: false
high_level_summary_instructions: ''
high_level_summary_placeholder: '@coderabbitai summary'
high_level_summary_in_walkthrough: false
auto_title_placeholder: '@coderabbitai'
auto_title_instructions: ''
review_status: true
review_details: false
commit_status: true
fail_commit_status: false
collapse_walkthrough: false
changed_files_summary: true
sequence_diagrams: false
estimate_code_review_effort: true
assess_linked_issues: true
related_issues: true
related_prs: true
suggested_labels: true
labeling_instructions: []
auto_apply_labels: false
suggested_reviewers: true
auto_assign_reviewers: false
in_progress_fortune: true
poem: false
enable_prompt_for_ai_agents: true
path_filters:
- '!vendor/**'
- '!**/vendor/**'
path_instructions:
- path: '**'
instructions: >-
-Focus on major issues impacting performance, readability,
maintainability and security. Avoid nitpicks and avoid verbosity.
abort_on_close: true
disable_cache: false
auto_review:
enabled: true
description_keyword: ''
auto_incremental_review: true
auto_pause_after_reviewed_commits: 5
ignore_title_keywords:
- WIP
- do-not-merge
- work-in-progress
labels:
- '!do-not-merge/work-in-progress'
drafts: false
base_branches: []
ignore_usernames: []
finishing_touches:
docstrings:
enabled: true
unit_tests:
enabled: true
simplify:
enabled: false
custom: []
pre_merge_checks:
override_requested_reviewers_only: false
docstrings:
mode: 'off'
threshold: 80
title:
mode: 'off'
requirements: ''
description:
mode: 'off'
issue_assessment:
mode: 'off'
custom_checks: []
tools:
ast-grep:
rule_dirs: []
util_dirs: []
essential_rules: true
packages: []
shellcheck:
enabled: true
ruff:
enabled: true
markdownlint:
enabled: true
github-checks:
enabled: true
timeout_ms: 90000
languagetool:
enabled: true
enabled_rules: []
disabled_rules: []
enabled_categories: []
disabled_categories: []
enabled_only: false
level: default
biome:
enabled: true
hadolint:
enabled: true
swiftlint:
enabled: true
phpstan:
enabled: true
level: default
phpmd:
enabled: true
phpcs:
enabled: true
golangci-lint:
enabled: true
yamllint:
enabled: true
gitleaks:
enabled: true
trufflehog:
enabled: true
checkov:
enabled: true
tflint:
enabled: true
detekt:
enabled: true
eslint:
enabled: true
flake8:
enabled: true
fortitudeLint:
enabled: true
rubocop:
enabled: true
buf:
enabled: true
regal:
enabled: true
actionlint:
enabled: true
pmd:
enabled: true
clang:
enabled: true
cppcheck:
enabled: true
opengrep:
enabled: true
semgrep:
enabled: true
circleci:
enabled: true
clippy:
enabled: true
sqlfluff:
enabled: true
trivy:
enabled: true
prismaLint:
enabled: true
pylint:
enabled: true
oxc:
enabled: true
shopifyThemeCheck:
enabled: true
luacheck:
enabled: true
brakeman:
enabled: true
dotenvLint:
enabled: true
htmlhint:
enabled: true
stylelint:
enabled: true
checkmake:
enabled: true
osvScanner:
enabled: true
blinter:
enabled: true
smartyLint:
enabled: true
emberTemplateLint:
enabled: true
psscriptanalyzer:
enabled: true
chat:
art: true
allow_non_org_members: true
auto_reply: true
integrations:
jira:
usage: disabled
linear:
usage: disabled
knowledge_base:
opt_out: true
web_search:
enabled: false
code_guidelines:
enabled: true
filePatterns: []
learnings:
scope: local
issues:
scope: auto
jira:
usage: disabled
project_keys: []
linear:
usage: disabled
team_keys: []
pull_requests:
scope: auto
mcp:
usage: disabled
disabled_servers: []
linked_repositories: []
code_generation:
docstrings:
language: en-US
path_instructions: []
unit_tests:
path_instructions: []
issue_enrichment:
auto_enrich:
enabled: true
planning:
enabled: true
auto_planning:
enabled: true
labels: []
labeling:
labeling_instructions: []
auto_apply_labels: false
|
|
@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: Overrode contexts on behalf of tmshort: ci/prow/openshift-e2e-aws-customnoupgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
No description provided.