Add aws-eusc cluster profile#4973
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughAdds a new cluster profile constant Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
|
@hector-vido Could you please help to review this PR? Thanks! |
|
/test e2e |
|
/hold |
|
@liweinan let's remove |
3913a61 to
f35e5ea
Compare
This commit adds support for the AWS European Sovereign Cloud (EUSC)
cluster profile for QE testing. The profile targets the eusc-de-east-1
region in AWS EUSC partition.
Changes:
- Add ClusterProfileAWSEUSCQE constant ("aws-eusc-qe")
- Add profile to ClusterProfiles() list
- Add profile to ClusterType() aws case
- Add LeaseType() mapping to "aws-eusc-qe"
Region Details:
- Region: eusc-de-east-1 (Brandenburg, Germany)
- Partition: aws-eusc
- Availability zones: eusc-de-east-1a, eusc-de-east-1b
Dependencies:
- Release repo PR for boskos/secret configuration
- Installer support: openshift/installer#10303
EUSC Service Endpoints (for reference):
- EC2: https://ec2.eusc-de-east-1.amazonaws.eu
- ELB: https://elasticloadbalancing.eusc-de-east-1.amazonaws.eu
- S3: https://s3.eusc-de-east-1.amazonaws.eu
- Route53: https://route53.amazonaws.eu
- IAM: https://iam.eusc-de-east-1.amazonaws.eu
- STS: https://sts.eusc-de-east-1.amazonaws.eu
- Tagging: https://tagging.eusc-de-east-1.amazonaws.eu
f35e5ea to
bf5238f
Compare
|
/unhold |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangxia, liweinan, yunjiang29 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@liweinan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build Error Analysis This integration test failure is not related to PR #4973. The PR only adds a new cluster profile constant in pkg/api/types.go and doesn't touch any Root Cause The testgrid-config-generator integration test is failing because of a mismatch between recent code changes and test fixtures: Recent Code Change (commit 355716a, Mar 3, 2026):
Test Fixtures Not Updated:
Impact:
Expected Behavior This test failure should affect all PRs currently running against the latest main branch, not just this PR. |
|
@liangxia This PR is ready to merge, could you please help to approve it again? Thanks! |
|
/retitle Add aws-eusc cluster profile |
|
/retest-required |
|
/override ci/prow/e2e |
|
@liangxia: Overrode contexts on behalf of liangxia: ci/prow/e2e DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4d4bab9
into
openshift:main
This commit adds support for the AWS European Sovereign Cloud (EUSC) cluster profile for QE testing. The profile targets the eusc-de-east-1 region in AWS EUSC partition.
Changes:
Region Details:
Dependencies:
EUSC Service Endpoints (for reference):
Summary by CodeRabbit