Skip to content

Add aws-eusc cluster profile#4973

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
liweinan:add-aws-eusc-qe-profile
Mar 10, 2026
Merged

Add aws-eusc cluster profile#4973
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
liweinan:add-aws-eusc-qe-profile

Conversation

@liweinan
Copy link
Contributor

@liweinan liweinan commented Feb 27, 2026

This commit adds support for the AWS European Sovereign Cloud (EUSC) cluster profile for QE testing. The profile targets the eusc-de-east-1 region in AWS EUSC partition.

Changes:

  • Add ClusterProfileAWSEUSCQE constant ("aws-eusc-qe")
  • Add profile to ClusterProfiles() list
  • Add profile to ClusterType() aws case
  • Add LeaseType() mapping to "aws-eusc-qe"

Region Details:

  • Region: eusc-de-east-1 (Brandenburg, Germany)
  • Partition: aws-eusc
  • Availability zones: eusc-de-east-1a, eusc-de-east-1b

Dependencies:

EUSC Service Endpoints (for reference):

Summary by CodeRabbit

  • New Features
    • Added a new AWS cluster profile "aws-eusc" — now publicly listed, classified as an AWS cloud type, and mapped to the corresponding lease type.

@openshift-ci-robot
Copy link
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

Walkthrough

Adds a new cluster profile constant ClusterProfileAWSEUSC ("aws-eusc") and registers it in the public profile list, maps it to the AWS cluster type in ClusterType(), and maps it to the "aws-eusc" lease type in LeaseType().

Changes

Cohort / File(s) Summary
Cluster profile & mappings
pkg/api/types.go
Added ClusterProfileAWSEUSC ("aws-eusc") constant; included it in ClusterProfiles() slice; added cases mapping it to AWS in ClusterType() and returning "aws-eusc" in LeaseType(). (No changes to LeaseTypeFromClusterType in this diff.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names ✅ Passed This PR only modifies type definitions file with no test files changed, making this check not applicable.
Test Structure And Quality ✅ Passed PR contains no test code modifications or additions, only non-test code changes to cluster profile constant.
Title check ✅ Passed The PR title 'Add aws-eusc cluster profile' accurately describes the main change: adding a new ClusterProfileAWSEUSC constant and related mappings for the aws-eusc cluster profile.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@liweinan
Copy link
Contributor Author

liweinan commented Mar 2, 2026

/retest

@liweinan
Copy link
Contributor Author

liweinan commented Mar 2, 2026

@hector-vido Could you please help to review this PR? Thanks!

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2026
@liangxia
Copy link
Member

liangxia commented Mar 3, 2026

/test e2e

@yunjiang29
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026
@yunjiang29
Copy link
Contributor

@liweinan let's remove qe postfix.

@liweinan liweinan force-pushed the add-aws-eusc-qe-profile branch from 3913a61 to f35e5ea Compare March 5, 2026 12:17
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
This commit adds support for the AWS European Sovereign Cloud (EUSC)
cluster profile for QE testing. The profile targets the eusc-de-east-1
region in AWS EUSC partition.

Changes:
- Add ClusterProfileAWSEUSCQE constant ("aws-eusc-qe")
- Add profile to ClusterProfiles() list
- Add profile to ClusterType() aws case
- Add LeaseType() mapping to "aws-eusc-qe"

Region Details:
- Region: eusc-de-east-1 (Brandenburg, Germany)
- Partition: aws-eusc
- Availability zones: eusc-de-east-1a, eusc-de-east-1b

Dependencies:
- Release repo PR for boskos/secret configuration
- Installer support: openshift/installer#10303

EUSC Service Endpoints (for reference):
- EC2: https://ec2.eusc-de-east-1.amazonaws.eu
- ELB: https://elasticloadbalancing.eusc-de-east-1.amazonaws.eu
- S3: https://s3.eusc-de-east-1.amazonaws.eu
- Route53: https://route53.amazonaws.eu
- IAM: https://iam.eusc-de-east-1.amazonaws.eu
- STS: https://sts.eusc-de-east-1.amazonaws.eu
- Tagging: https://tagging.eusc-de-east-1.amazonaws.eu
@liweinan liweinan force-pushed the add-aws-eusc-qe-profile branch from f35e5ea to bf5238f Compare March 5, 2026 12:35
@yunjiang29
Copy link
Contributor

/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2026
@yunjiang29
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia, liweinan, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yunjiang29
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@liweinan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes bf5238f link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liweinan
Copy link
Contributor Author

liweinan commented Mar 6, 2026

Build Error Analysis

This integration test failure is not related to PR #4973. The PR only adds a new cluster profile constant in pkg/api/types.go and doesn't touch any
testgrid-related code.

Root Cause

The testgrid-config-generator integration test is failing because of a mismatch between recent code changes and test fixtures:

Recent Code Change (commit 355716a, Mar 3, 2026):

  • Updated hardcoded job name prefixes in cmd/testgrid-config-generator/main.go:262-264
  • Changed from periodic-ci-openshift-release-master-* → periodic-ci-openshift-release-main-*

Test Fixtures Not Updated:

  • Jobs in test/integration/testgrid-config-generator/config/jobs/org/repo/org-repo-master-periodics.yaml still use the old naming:
    • periodic-ci-openshift-release-master-ci-4.10-e2e-aws-ovn-upgrade
    • periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade

Impact:

  • These jobs no longer match the prefix check (line 262 in main.go)
  • They fail stream detection and return early (line 286-287)
  • Expected dashboard files are not generated:
    • redhat-openshift-ocp-release-4.10-blocking.yaml
    • redhat-openshift-ocp-release-4.10-informing.yaml

Expected Behavior

This test failure should affect all PRs currently running against the latest main branch, not just this PR.

@liweinan
Copy link
Contributor Author

@liangxia This PR is ready to merge, could you please help to approve it again? Thanks!

@liangxia
Copy link
Member

/retitle Add aws-eusc cluster profile

@openshift-ci openshift-ci bot changed the title Add aws-eusc-qe cluster profile Add aws-eusc cluster profile Mar 10, 2026
@liangxia
Copy link
Member

/retest-required

@liangxia
Copy link
Member

/override ci/prow/e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2026

@liangxia: Overrode contexts on behalf of liangxia: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4d4bab9 into openshift:main Mar 10, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants