Skip to content

[fournos-launcher] Test v0.4.0#53

Open
kpouget wants to merge 2 commits intoopenshift-psap:mainfrom
kpouget:test
Open

[fournos-launcher] Test v0.4.0#53
kpouget wants to merge 2 commits intoopenshift-psap:mainfrom
kpouget:test

Conversation

@kpouget
Copy link
Copy Markdown
Contributor

@kpouget kpouget commented May 5, 2026

Summary by CodeRabbit

  • Chores
    • Refactored namespace configuration management for FournosJob operations. Updated how workload namespaces are resolved and specified throughout the CI pipeline for consistency across resolution and export workflows.

Review Change Stack

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sjmonson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 94e071de-6c9e-462c-8599-2fbd18d970a0

📥 Commits

Reviewing files that changed from the base of the PR and between 78766cf and ef5545a.

📒 Files selected for processing (3)
  • WIP
  • projects/core/ci_entrypoint/fournos_resolve.py
  • projects/core/library/export.py

📝 Walkthrough

Walkthrough

This PR migrates environment variable naming from FOURNOS_NAMESPACE to FOURNOS_WORKLOAD_NAMESPACE across the FournosJob resolution and export modules. The fetch function, CLI option binding, and export status workflow are updated consistently to reference the new variable name.

Changes

Namespace Environment Variable Migration

Layer / File(s) Summary
Fetch Function Validation
projects/core/ci_entrypoint/fournos_resolve.py
fetch_fournos_job() reads namespace from FOURNOS_WORKLOAD_NAMESPACE and raises ValueError if missing.
CLI Option and Environment Binding
projects/core/ci_entrypoint/fournos_resolve.py
--namespace Click option help and envvar parameter reference FOURNOS_WORKLOAD_NAMESPACE; option handler sets os.environ["FOURNOS_WORKLOAD_NAMESPACE"].
Export Status Workflow
projects/core/library/export.py
_update_fjob_export_status() reads FOURNOS_WORKLOAD_NAMESPACE when constructing oc commands for FournosJob status patching.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A namespace rename, clean and neat,
From OLD to WORKLOAD, a migration complete,
Two files aligned in harmony,
Kubernetes jobs fetch with clarity,
The config now sings a consistent beat! 🎵

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '[fournos-launcher] Test v0.4.0' is vague and does not clearly convey the actual changes made in the PR, which involve updating namespace environment variable references from FOURNOS_NAMESPACE to FOURNOS_WORKLOAD_NAMESPACE across core modules. Consider revising the title to be more specific and descriptive of the main change, e.g., '[core] Use FOURNOS_WORKLOAD_NAMESPACE instead of FOURNOS_NAMESPACE' or similar, to better reflect the actual code modifications.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kpouget kpouget changed the title [fourno] Test v0.4.0 [fournos-launcher] Test v0.4.0 May 5, 2026
@kpouget
Copy link
Copy Markdown
Contributor Author

kpouget commented May 11, 2026

/test fournos skeleton quick_test
/var fournos.namespace: psap-automation-wip
/cluster psap-mgmt

@psap-forge-bot
Copy link
Copy Markdown

🔴 Test of 'fournos_launcher submit' failed after 00 hours 01 minutes 11 seconds 🔴

• Link to the test results.

• No reports generated...

Test configuration:

/test fournos skeleton quick_test
/var fournos.namespace: psap-automation-wip
/cluster psap-mgmt

• Failure indicator: Empty.
Execution logs

@kpouget
Copy link
Copy Markdown
Contributor Author

kpouget commented May 11, 2026

/test fournos skeleton quick_test
/var fournos.namespace: psap-automation-wip
/cluster psap-mgmt

@psap-forge-bot
Copy link
Copy Markdown

🟢 Test of 'skeleton test' succeeded after 00 hours 00 minutes 10 seconds 🟢

• Link to the test results.

• Generated 2 Caliper report(s):

  • summary_table.html
  • throughput_chart.html

Test configuration:

ci_job.cluster: psap-mgmt
ci_job.exclusive: true
ci_job.fjob: forge-skeleton-20260511-112523
ci_job.hardware:
  gpuCount: 4
  gpuType: h200
ci_job.name: skeleton quick_test
ci_job.owner: kpouget
project.args:
- quick_test
project.name: skeleton

Execution logs

@psap-forge-bot
Copy link
Copy Markdown

🟢 Test of 'fournos_launcher submit' succeeded after 00 hours 01 minutes 28 seconds 🟢

• Link to the test results.

• No reports generated...

Test configuration:

/test fournos skeleton quick_test
/var fournos.namespace: psap-automation-wip
/cluster psap-mgmt

Execution logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant