Skip to content

Remove caching venv#503

Merged
mgoerens merged 1 commit intoopenshift-helm-charts:mainfrom
mgoerens:remove_venv_cache
Mar 19, 2026
Merged

Remove caching venv#503
mgoerens merged 1 commit intoopenshift-helm-charts:mainfrom
mgoerens:remove_venv_cache

Conversation

@mgoerens
Copy link
Contributor

Temporarily removes the caching mechanism of the python venv as it could cause running out-of-date versions of our CI scripts.

The cache key should not remain constant accross source code changes.

While we explore alternative options, this ensures that the venv is completely rebuilt each time we install the CI scripts, thus ensuring the scripts that we run are up-to-date.

Temporarily removes the caching mechanism of the python venv as it could
cause running out-of-date versions of our CI scripts.

The cache key should not remain constant accross source code changes.

While we explore alternative options, this ensures that the venv is
completely rebuilt each time we install the CI scripts, thus ensuring
the scripts that we run are up-to-date.

Signed-off-by: Matthias Goerens <mgoerens@redhat.com>
This was referenced Mar 17, 2026
@mgoerens mgoerens requested a review from komish March 17, 2026 23:55
@komish
Copy link
Contributor

komish commented Mar 19, 2026

This was done at some point to expedite CI and make sure we don't hit timeouts. I think our CI is at a point now where this may make a noticeable difference, but removing the cache should still keep us within our window.

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mgoerens
Copy link
Contributor Author

Let's monitor the time it takes for the Nightly to complete tonight

@mgoerens mgoerens merged commit d07dcd0 into openshift-helm-charts:main Mar 19, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants