Enable smoke testing on PR label#500
Open
komish wants to merge 1 commit intoopenshift-helm-charts:mainfrom
Open
Enable smoke testing on PR label#500komish wants to merge 1 commit intoopenshift-helm-charts:mainfrom
komish wants to merge 1 commit intoopenshift-helm-charts:mainfrom
Conversation
Repo maintainers can now label a pull request with the trusted label to allow the smoke testing of the content of a pull request. Original intent is to allow a maintainer to run tests against a dependabot PR. Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
This was referenced Mar 12, 2026
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo maintainers can now label a pull request with the trusted label to allow the smoke testing of the content of a pull request. Original intent is to allow a maintainer to run tests against a dependabot PR.
NOTE:
When dependabot creates a pull requests, there are two test-related workflows that start: release.yml and test.yml.
release.yml fails because it's configured to fail outright if the contributor is not an approved contributor. This will continue to be the case for now when dependabot submits a PR, and will need to be reworked in the future.
test.yml succeeds without running any tests (which effectively means it just skips testing). Therefore, this is not currently seen as a failing test when dependabot submits a pull request.
I think there's an opportunity to refactor both release.yml and test.yml to utilize the label-based approach I'm implementing here, but until then, we still want to be testing dependabot PRs so that we do not have to recreate them for them to be tested as seen in #497.