Add editing capabilities to the release process#498
Merged
mgoerens merged 1 commit intoopenshift-helm-charts:mainfrom Mar 13, 2026
Merged
Add editing capabilities to the release process#498mgoerens merged 1 commit intoopenshift-helm-charts:mainfrom
mgoerens merged 1 commit intoopenshift-helm-charts:mainfrom
Conversation
This commit extends the range of actions that can be defined in the release_info.json to add the "edit" keyword. "edit" maps a path (to a workflow) to a callable. The callable must be defined in the ALLOWED_EDIT_FUNCTION dict, and must accepts a single argument (the path to the workflow to edit). This commit also adds an edit function that modifies the trigger of a workflow from pull_request to pull_request_target. Signed-off-by: Matthias Goerens <mgoerens@redhat.com>
This was referenced Mar 12, 2026
Contributor
Author
|
There seems to be a linting error for a file that hasn't been modified by this PR. Not sure why this would pop up now, but we should address it separately. |
jsm84
approved these changes
Mar 12, 2026
Contributor
jsm84
left a comment
jsm84
left a comment
There was a problem hiding this comment.
LGTM.
This allows pull_request workflows to exist in dev, while updating affected workflows to use pull_request_target for prod and stage upon release. I'd say it fits the bill.
Contributor
|
@mgoerens I opened up a separate PR for the linting error, and I'm disregarding here. |
komish
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the range of actions that can be defined in the release_info.json to add the "edit" keyword. "edit" maps a path (to a workflow) to a callable. The callable must be defined in the ALLOWED_EDIT_FUNCTION dict, and must accepts a single argument (the path to the workflow to edit).
This commit also adds an edit function that modifies the trigger of a workflow from pull_request to pull_request_target.
Tested in fork with following adjustments:
Note following divergences between my forks and the actual repos. These differences should be irrelevant with regards to the changes discussed in this PR:
GitHub Actions is not permitted to approve pull requestsin my fork of development. This isn't fixed on purpose to avoid having to revert the release after each of my tests.