Skip to content

[BUG] Deadlock prone code in HttpConnection.cs #689 #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidPoulsenHGS wants to merge 1 commit into from
Closed

[BUG] Deadlock prone code in HttpConnection.cs #689 #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/OpenSearch.Net/Connection/HttpConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,9 @@ public virtual TResponse Request<TResponse>(RequestData requestData)

if (requestData.ThreadPoolStats)
threadPoolStats = ThreadPoolStats.GetStats();

responseMessage = client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead).GetAwaiter().GetResult();
var task = Task.Run(() => client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead));

@joefeser joefeser Aug 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you looked at using client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead).ConfigureAwait(false)?

@Salgat Salgat May 13, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joefeser .ConfigureAwait(false) is not needed inside a Task.Run since there is no synchronization context to capture.

task.Wait();
responseMessage = task.Result;
statusCode = (int)responseMessage.StatusCode;
d.EndState = statusCode;
}
Expand All @@ -120,7 +121,9 @@ public virtual TResponse Request<TResponse>(RequestData requestData)
if (responseMessage.Content != null)
{
receive = DiagnosticSource.Diagnose(DiagnosticSources.HttpConnection.ReceiveBody, requestData, statusCode);
responseStream = responseMessage.Content.ReadAsStreamAsync().GetAwaiter().GetResult();
var task = Task.Run(() => responseMessage.Content.ReadAsStreamAsync());

@joefeser joefeser Aug 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you considered just changing it to responseMessage.Content.ReadAsStreamAsync().ConfigureAwait(false)?

task.Wait();
responseStream = task.Result;
}
}
catch (TaskCanceledException e)
Expand Down