Skip to content

Conversation

@karenyrx
Copy link
Collaborator

@karenyrx karenyrx commented Dec 4, 2025

Description

  1. tags schema is missing "default" option

  2. Fields supports object or array type. If object type, then useExplicitFieldOrder is set to false. If array type, then true. Code path:

1. JSON parser encounters "fields": ...
2. Checks if it's { (object) or [ (array)
3. If [ (array) → calls orderedModeCallback → sets useExplicitFieldOrder(true)
5. If { (object) → callback never called → useExplicitFieldOrder stays false

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Changes Analysis

Commit SHA: 0e0424a
Comparing To SHA: 5432cfd

API Changes

Summary

└─┬Components
  ├──[➕] schemas (51137:7)
  └─┬_core.search___HighlighterTagsSchema
    └──[➕] enum (51121:11)

Document Element Total Changes Breaking Changes
components 2 0
  • Total Changes: 2
  • Additions: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/20044558752/artifacts/4803713483

API Coverage

Before After Δ
Covered (%) 666 (65.23 %) 666 (65.23 %) 0 (0 %)
Uncovered (%) 355 (34.77 %) 355 (34.77 %) 0 (0 %)
Unknown 129 129 0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Spec Test Coverage Analysis

Total Tested
682 680 (99.71 %)

lucy66hw
lucy66hw previously approved these changes Dec 4, 2025
@karenyrx karenyrx marked this pull request as ready for review December 4, 2025 21:33
karenx added 2 commits December 8, 2025 21:37
@lucy66hw lucy66hw merged commit 963f902 into opensearch-project:main Dec 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants