-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Make truncate filter a normalizer token filter #19779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make truncate filter a normalizer token filter #19779
Conversation
|
❕ Gradle check result for ac51c6c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19779 +/- ##
============================================
- Coverage 73.27% 73.26% -0.01%
+ Complexity 71553 71519 -34
============================================
Files 5789 5789
Lines 327144 327144
Branches 47156 47156
============================================
- Hits 239715 239684 -31
+ Misses 68235 68206 -29
- Partials 19194 19254 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ac51c6c to
84d46c5
Compare
Relates to opensearch-project/OpenSearch#19779 Signed-off-by: David Causse <[email protected]>
|
Hi @nomoa , could you add some yaml test cases for this change? |
84d46c5 to
651129e
Compare
|
❌ Gradle check result for 651129e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@gaobinlong thanks for taking a look at this PR, I added a quick entry in the existing yaml test for the truncate filter. |
This filter may be useful with keyword fields if preferring to truncate the data rather than ignoring it (ignore above). Move and re-purpose the TruncateTokenFilterTests from the server module to analysis-common (the lucene truncate filter has moved to lucene a long time ago). Signed-off-by: David Causse <[email protected]>
651129e to
2e6541e
Compare
Signed-off-by: Andrew Ross <[email protected]>
Relates to opensearch-project/OpenSearch#19779 Signed-off-by: David Causse <[email protected]>
Relates to opensearch-project/OpenSearch#19779 Signed-off-by: David Causse <[email protected]>
Description
This filter may be useful with keyword fields if preferring to truncate the data rather than ignoring it (ignore above).
Move and re-purpose the TruncateTokenFilterTests from the server module to analysis-common (the lucene truncate filter has moved to lucene a long time ago).
Related Issues
Resolves #19778
Check List
[ ] API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.