-
Notifications
You must be signed in to change notification settings - Fork 102
Recipes to find ThreadLocals and determine their mutation
#875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MBoegers
wants to merge
10
commits into
main
Choose a base branch
from
boeg/find-thread-local
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs another round of personal review, but open for comments. |
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/search/FindThreadLocalsMutableFromOutside.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/threadlocal/AbstractFindThreadLocals.java
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Outdated
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/AbstractFindThreadLocals.java
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
src/main/java/org/openrewrite/java/migrate/search/threadlocal/FindNeverMutatedThreadLocals.java
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
...java/org/openrewrite/java/migrate/search/threadlocal/FindThreadLocalsMutableFromOutside.java
Show resolved
Hide resolved
MBoegers
commented
Oct 17, 2025
.../openrewrite/java/migrate/search/threadlocal/FindThreadLocalsMutatedOnlyInDefiningScope.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/search/threadlocal/AbstractFindThreadLocals.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR introduces a comprehensive suite of search recipes to identify
ThreadLocalvariables that could be migrated toScopedValuein Java 25+ (JEP 506):What's your motivation?
Java 25 introduces
ScopedValueas a modern alternative toThreadLocalfor immutable thread-local values, offering:Unfortunately not all
ThreadLocalinstances qualify equally.These recipes help development teams:
Anything in particular you'd like reviewers to focus on?
AbstractFindThreadLocalsbase class uses scanning to detect mutations across multiple compilation units. Please verify this correctly handles all edge cases.Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist