Update README.md examples and project structure#3
Open
DryByte wants to merge 4 commits intoopenmultiplayer:masterfrom
Open
Update README.md examples and project structure#3DryByte wants to merge 4 commits intoopenmultiplayer:masterfrom
DryByte wants to merge 4 commits intoopenmultiplayer:masterfrom
Conversation
Author
|
Just curious, but do we really need to add it as a subdirectory and link it? Since it's a single header, it will already be compiled by the program when the header is included. |
Since the file isn't in the same folder, doesn't make sense to use quotes instead of brackets.
Member
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in README.md is outdated, so you can't actually use it for creating a component from a "basic setup", having the need to dig a little bit in the server and the SDK code to understand what's happening...
And the
target_link_librariesis trying to link the wrong library name, so i updated it as well.Updated the project structure to include the tools folder