Skip to content

Conversation

@JATAYU000
Copy link
Contributor

Metadata

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 57.45721% with 174 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.32%. Comparing base (c5f68bf) to head (96df5e3).

Files with missing lines Patch % Lines
openml/_api/resources/datasets.py 31.55% 128 Missing ⚠️
openml/datasets/functions.py 6.66% 14 Missing ⚠️
openml/_api/http/client.py 82.60% 12 Missing ⚠️
openml/_api/resources/tasks.py 87.23% 6 Missing ⚠️
openml/_api/runtime/fallback.py 0.00% 6 Missing ⚠️
openml/_api/runtime/core.py 81.48% 5 Missing ⚠️
openml/_api/__init__.py 75.00% 1 Missing ⚠️
openml/_api/config.py 96.87% 1 Missing ⚠️
openml/tasks/functions.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   53.02%   53.32%   +0.29%     
==========================================
  Files          36       46      +10     
  Lines        4326     4645     +319     
==========================================
+ Hits         2294     2477     +183     
- Misses       2032     2168     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JATAYU000
Copy link
Contributor Author

FYI @geetu040 Currently the get_dataset() function has 3 download requirement

  • download_data : uses api_calls._download_minio_bucket() to download all the files in the bucket if download_all_files param was True and api_calls._download_minio_file() to download the dataset.pq file if it was not found in cache. When download parquet fails it fallback to download dataset.arff file with get and does checksum
  • download_features : does get request and caches the xml and saves the file path to feature_file param in OpenMLDataset
  • download_qualities : does get request and caches the xml and saves the file path to qualities_file param in OpenMLDataset

These two features and qualities in v2 would have a json response instead of xml, on top of saving that to cache the file path needs to returned for the OpenMLDataset object, later processing of these files should handle xml/json according the the file path extension since the download could have been xml/json depending on v1/v2

@geetu040 geetu040 mentioned this pull request Jan 9, 2026
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants