re-implement import-sql using Python#378
Draft
nyurik wants to merge 5 commits intoopenmaptiles:masterfrom
Draft
Conversation
Falke-Design
referenced
this pull request
in openmaptiles/openmaptiles
Oct 2, 2021
Because of the parallel processing of `import-sql` the error message is printed in the middle of the output. With this PR the error is displayed again at the end:  Issue: openmaptiles/openmaptiles-tools#370 ``` awk '1{print; fflush()} $$0~".*ERROR" {txt=$$0} END{ if(txt){print "\n*** ERROR detected, aborting:"; print txt; exit(1)} }' ``` Explanation: - `1{print; fflush()}` means if true then print output -> `1{}` same as `if(true){}` - `$$0~".*ERROR" {txt=$$0}` get first argument `$$0` (line of output) and check if it contains (regex string) `ERROR`. If true save line to var `txt`: `{txt=$$0}` - `END{ ... }` if last line of output is reached - `if(txt){print "\n*** ERROR detected, aborting:"; print txt; exit(1)}` if error was found in a line / var `txt` is existing print it out
TomPohys
reviewed
Oct 6, 2021
TomPohys
reviewed
Oct 6, 2021
Co-authored-by: Tomas Pohanka <TomPohys@gmail.com>
TomPohys
approved these changes
Oct 6, 2021
Member
|
Thanks! Is this also fixing #373? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #376