7904101: intermittent failure in StreamsTest.agentvm.ok #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
vpa1977
force-pushed
the
synchronize_stdot
branch
from
6335c57 to
49d53af
Compare
Webrevs
|
How it works:
- The agent vm emits separator text before and after the text.
- The main vm send the action and waits for the separator text line from
the agent vm.
- After the result have been read by the main vm it expects another separator
text line. After consuming the line it redirects output to the agent log.
Edge cases:
- Timeouts and Agent VM crashes:
- The main vm's stdout and stderr tasks will exit due to the
closed stream. The main vm is supposed to dispose the failed agent.
vpa1977
force-pushed
the
synchronize_stdot
branch
from
49d53af to
66bd56f
Compare
Author
|
Still getting intermittent failure in StreamsTest. moving to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileDescriptor test intermittently fails because the agent's process output capture lacks synchronisation.
This PR fixes the issue:
Alternative:
-Disable the test and make no assumptions about contents of the agent vm process output.
Testing: tier1 and tier2 tests on mainline jdk (Ubuntu Linux) in agentvm mode.
Unrelated failure: test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/295/head:pull/295$ git checkout pull/295Update a local copy of the PR:
$ git checkout pull/295$ git pull https://git.openjdk.org/jtreg.git pull/295/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 295View PR using the GUI difftool:
$ git pr show -t 295Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/295.diff
Using Webrev
Link to Webrev Comment