-
Notifications
You must be signed in to change notification settings - Fork 199
8470: Unresolved placeholders shown in JFR result overview's table mode #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into |
|
@aymane-harmaz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@aymane-harmaz |
|
/sponsor |
|
Going to push as commit 2c9ad54.
Your commit was automatically rebased without conflicts. |
|
@thegreystone @aymane-harmaz Pushed as commit 2c9ad54. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR populates the summary, explanation, and solution fields of a rule displayed in the result overview table with the actual evaluated values.
The following screenshots show the state before and after the change.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/684/head:pull/684$ git checkout pull/684Update a local copy of the PR:
$ git checkout pull/684$ git pull https://git.openjdk.org/jmc.git pull/684/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 684View PR using the GUI difftool:
$ git pr show -t 684Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/684.diff
Using Webrev
Link to Webrev Comment