-
Notifications
You must be signed in to change notification settings - Fork 534
8368691: Update libxml2 to 2.14.6 #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Reviewers: @kevinrushforth @tiainen /reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Sanity test build is green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All builds ran fine.
/integrate |
Going to push as commit 6ab42f9.
Your commit was automatically rebased without conflicts. |
@HimaBinduMeda Pushed as commit 6ab42f9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Updated libxml2 to v2.14.6. Verified build on all platforms. No issue seen.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1920/head:pull/1920
$ git checkout pull/1920
Update a local copy of the PR:
$ git checkout pull/1920
$ git pull https://git.openjdk.org/jfx.git pull/1920/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1920
View PR using the GUI difftool:
$ git pr show -t 1920
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1920.diff
Using Webrev
Link to Webrev Comment