-
Notifications
You must be signed in to change notification settings - Fork 20
8341778: Some javac tests ignore the result of JavacTask::call #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of JDK-8341778: Some javac tests ignore the result of JavacTask::call. The commit improves existing tests by preventing silent errors propagated in tests that use "JavacTask.call()". It doesn't introduce behavioral changes. |
|
|
|
/approval request for backport of JDK-8341778: Some javac tests ignore the result of JavacTask::call. The commit improves existing tests by preventing silent errors propagated in tests that use "JavacTask.call()". It doesn't introduce behavioral changes. |
Backporting JDK-8341778: Some javac tests ignore the result of JavacTask::call.
Multiple tests ignore the Boolean return value from JavacTask.call(), causing silent failures where tests appear to pass despite actual compilation errors. This fix adds result validation to all affected test cases.. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/beans
(Passed) - make test TEST=test/hotspot/jtreg/vmTestbase/gc/g1/unloading
Results are attached.
linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log
windows-x64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/40/head:pull/40$ git checkout pull/40Update a local copy of the PR:
$ git checkout pull/40$ git pull https://git.openjdk.org/jdk25u-dev.git pull/40/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 40View PR using the GUI difftool:
$ git pr show -t 40Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/40.diff
Using Webrev
Link to Webrev Comment