-
Couldn't load subscription status.
- Fork 232
8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
GHA failure: test java/lang/ProcessBuilder/Basic#id0 failed. Unrelated. |
|
GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8314136
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
I backport this for parity with 17.0.18-oracle.
Clean backport, but need to adapt as HttpClient does not implement
AutoClosable in 17.
Omitted calls to close, test is run as othervm.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4109/head:pull/4109$ git checkout pull/4109Update a local copy of the PR:
$ git checkout pull/4109$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4109/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4109View PR using the GUI difftool:
$ git pr show -t 4109Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4109.diff
Using Webrev
Link to Webrev Comment